From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "Michal Suchánek" <msuchanek@suse.de>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"David C. Rankin" <drankinatty@gmail.com>,
git@vger.kernel.org
Subject: Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
Date: Wed, 26 Jun 2024 11:51:46 -0700 [thread overview]
Message-ID: <xmqq4j9fzge5.fsf@gitster.g> (raw)
In-Reply-To: <aa94be27-60a5-42d9-adcc-f25f9a8d6ae5@gmail.com> (Phillip Wood's message of "Wed, 26 Jun 2024 19:35:32 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Sorry if I wasn't clear. "." is considered safe with "safe.directory =
> *" but I was looking at why it was not considered safe when using
> repository paths in safe.directory.
Ahh, OK. We tell them /home/wood/repo/git is a good repository to
visit, but daemon's call to ensure_valid_ownership() asks "I am in
the '.' directory; does that match /home/wood/repo/git?"
That sucks. I agree with your idea that we'd need to canonicalize
both before comparing.
THanks.
next prev parent reply other threads:[~2024-06-26 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 0:36 Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1 David C. Rankin
2024-06-17 18:47 ` Junio C Hamano
2024-06-17 21:15 ` Michal Suchánek
2024-06-25 7:24 ` Michal Suchánek
2024-06-25 16:12 ` Junio C Hamano
2024-06-25 18:34 ` Michal Suchánek
2024-06-26 13:03 ` Phillip Wood
2024-06-26 18:14 ` Junio C Hamano
2024-06-26 18:35 ` Phillip Wood
2024-06-26 18:51 ` Junio C Hamano [this message]
2024-09-25 11:34 ` Michal Suchánek
2024-08-29 20:34 ` Joey Hess
2024-07-26 0:38 ` Jamie Landeg-Jones
2024-07-26 5:58 ` David C. Rankin
2024-07-28 3:46 ` Jamie Landeg-Jones
2024-07-28 6:57 ` David C. Rankin
2024-08-01 0:15 ` [SOLVED] " Jamie Landeg-Jones
2024-08-02 19:31 ` Junio C Hamano
2024-06-18 1:08 ` David C. Rankin
2024-06-24 14:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4j9fzge5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=drankinatty@gmail.com \
--cc=git@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).