git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Eric Sunshine <sunshine@sunshineco.com>,  git@vger.kernel.org
Subject: Re: chainlint test failing on Linux sparc64
Date: Mon, 20 May 2024 09:04:30 -0700	[thread overview]
Message-ID: <xmqq4jasmpv5.fsf@gitster.g> (raw)
In-Reply-To: <46caaa2d204844cbe5625428ece5b2fe8656364b.camel@physik.fu-berlin.de> (John Paul Adrian Glaubitz's message of "Mon, 20 May 2024 13:02:46 +0200")

John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> writes:

> Hi Eric,
> ...
> In order to verify this theory, I made the following temporary change:
>
> diff --git a/t/chainlint.pl b/t/chainlint.pl
> index 556ee91a15..63cac942ac 100755
> --- a/t/chainlint.pl
> +++ b/t/chainlint.pl
> @@ -718,7 +718,7 @@ sub ncores {
>         # Windows
>         return $ENV{NUMBER_OF_PROCESSORS} if exists($ENV{NUMBER_OF_PROCESSORS});
>         # Linux / MSYS2 / Cygwin / WSL
> -       do { local @ARGV='/proc/cpuinfo'; return scalar(grep(/^processor[\s\d]*:/, <>)); } if -r '/proc/cpuinfo';
> +       do { local @ARGV='/proc/cpuinfo'; return scalar(grep(/^processor[\s\d]*:||^CPU[\d]*:/, <>)); } if -r '/proc/cpuinfo';
>         # macOS & BSD
>         return qx/sysctl -n hw.ncpu/ if $^O =~ /(?:^darwin$|bsd)/;
>         return 1;
>
> and I confirm that this fixes the problem.
>
> Let me whip up a patch and post it here.

Thanks for working so well together.  Very much appreciated.

  reply	other threads:[~2024-05-20 16:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  7:56 chainlint test failing on Linux sparc64 John Paul Adrian Glaubitz
2024-05-20  8:21 ` Eric Sunshine
2024-05-20  8:24   ` John Paul Adrian Glaubitz
2024-05-20  9:04     ` John Paul Adrian Glaubitz
2024-05-20  9:36       ` Eric Sunshine
2024-05-20  9:56         ` John Paul Adrian Glaubitz
2024-05-20  9:58         ` Eric Sunshine
2024-05-20 10:02           ` John Paul Adrian Glaubitz
2024-05-20 11:02             ` John Paul Adrian Glaubitz
2024-05-20 16:04               ` Junio C Hamano [this message]
2024-05-20 16:07                 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4jasmpv5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).