From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Yehezkel Bernat via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Yehezkel Bernat <yehezkelshb@gmail.com>
Subject: Re: [PATCH] Documentation: fix linkgit reference
Date: Mon, 15 Apr 2024 11:02:26 -0700 [thread overview]
Message-ID: <xmqq4jc2o66l.fsf@gitster.g> (raw)
In-Reply-To: <ZhzVnnoBFt2nau4x@tanuki> (Patrick Steinhardt's message of "Mon, 15 Apr 2024 09:22:06 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Sun, Apr 14, 2024 at 10:08:02PM +0000, Yehezkel Bernat via GitGitGadget wrote:
>> From: Yehezkel Bernat <yehezkelshb@gmail.com>
>>
>> In git-replay documentation, linkgit to git-rev-parse is missing the man
>> section which breaks its rendering
>>
>> Add section number as done in other references to this command
>
> Nit: sentences should end with a dot.
>
>> Signed-off-by: Yehezkel Bernat <YehezkelShB@gmail.com>
>
> Other than that this patch looks good to me, thanks!
>
> Patrick
Thanks, both. Will just tweak the proposed log message while
queuing.
>> ---
>> Documentation: fix linkgit reference
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1706%2FYehezkelShB%2Fyb%2Ffix-linkgit-reference-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1706/YehezkelShB/yb/fix-linkgit-reference-v1
>> Pull-Request: https://github.com/git/git/pull/1706
>>
>> Documentation/git-replay.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/git-replay.txt b/Documentation/git-replay.txt
>> index f6c269c62d5..8f3300c683a 100644
>> --- a/Documentation/git-replay.txt
>> +++ b/Documentation/git-replay.txt
>> @@ -46,7 +46,7 @@ the new commits (in other words, this mimics a cherry-pick operation).
>> Range of commits to replay. More than one <revision-range> can
>> be passed, but in `--advance <branch>` mode, they should have
>> a single tip, so that it's clear where <branch> should point
>> - to. See "Specifying Ranges" in linkgit:git-rev-parse and the
>> + to. See "Specifying Ranges" in linkgit:git-rev-parse[1] and the
>> "Commit Limiting" options below.
>>
>> include::rev-list-options.txt[]
>>
>> base-commit: 8f7582d995682f785e80e344197cc715e6bc7d8e
>> --
>> gitgitgadget
>>
prev parent reply other threads:[~2024-04-15 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 22:08 [PATCH] Documentation: fix linkgit reference Yehezkel Bernat via GitGitGadget
2024-04-15 7:22 ` Patrick Steinhardt
2024-04-15 18:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jc2o66l.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).