From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] builtin/repack.c: only collect fully-formed packs
Date: Mon, 12 Jun 2023 14:00:21 -0700 [thread overview]
Message-ID: <xmqq4jnc9z16.fsf@gitster.g> (raw)
In-Reply-To: <20230607101617.ges6tnMry4E52lDGld43QgtNUsIS4YQq6w-t71hEfkQ@z> (Taylor Blau's message of "Wed, 7 Jun 2023 06:16:17 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> Fix the above by teaching `collect_pack_filenames()` to only collect
> packs with their corresponding `*.idx` files in place, indicating that
> those packs have been fully staged.
Hmph, after following the problem description (which by the way was
very well written), I expected to see "collect_pack_filenames() is
taught to use get_all_packs() and then enumerate the names from the
in-core packed_git structures---this way there is no possibility for
the two methods to produce inconsistent results".
But that is not what is going on. Rather, it is "we still keep
using a separate readdir() loop, but made sure that the criteria to
include a packfile in the result is identical to the logic currently
used by the other function", whose implication is that they can
diverge again. I am somewhat puzzled.
Will queue. Thanks.
next prev parent reply other threads:[~2023-06-12 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 10:16 [PATCH] builtin/repack.c: only collect fully-formed packs Taylor Blau
2023-06-07 10:16 ` Taylor Blau
2023-06-12 21:00 ` Junio C Hamano [this message]
2023-06-07 13:51 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jnc9z16.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).