git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, phillip.wood@dunelm.org.uk,
	sunshine@sunshineco.com, Toon Claes <toon@iotcl.com>
Subject: Re: [PATCH v6 2/2] attr: add flag `--source` to work with tree-ish
Date: Fri, 13 Jan 2023 14:19:38 -0800	[thread overview]
Message-ID: <xmqq4jsu13id.fsf@gitster.g> (raw)
In-Reply-To: <57f5957127ce3be2621445806f2f00857ac8b1aa.1673521102.git.karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 12 Jan 2023 12:00:31 +0100")

Karthik Nayak <karthik.188@gmail.com> writes:

> diff --git a/attr.h b/attr.h
> index 3fb40cced0..f4a2bedd68 100644
> --- a/attr.h
> +++ b/attr.h
> @@ -1,6 +1,8 @@
>  #ifndef ATTR_H
>  #define ATTR_H
>  
> +#include "hash.h"

You only want "struct object_id" declared.  Why include the whole
file?

  reply	other threads:[~2023-01-13 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <https://lore.kernel.org/git/cover.1671793109.git.karthik.188@gmail.com/>
2023-01-12 11:00 ` [PATCH v6 0/2] check-attr: add support to work with tree-ish Karthik Nayak
2023-01-12 11:00   ` [PATCH v6 1/2] t0003: move setup for `--all` into new block Karthik Nayak
2023-01-12 11:00   ` [PATCH v6 2/2] attr: add flag `--source` to work with tree-ish Karthik Nayak
2023-01-13 22:19     ` Junio C Hamano [this message]
2023-01-14  8:23       ` Karthik Nayak
2023-01-13 10:27   ` [PATCH v6 0/2] check-attr: add support " Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4jsu13id.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sunshine@sunshineco.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).