From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] symbolic-ref: teach "--[no-]recurse" option
Date: Fri, 07 Oct 2022 21:20:44 -0700 [thread overview]
Message-ID: <xmqq4jwfc5er.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQZ_SehTLoFEtBf2Xv=8iw3-DkjQfP3R9J8kUm3DjkLBw@mail.gmail.com> (Eric Sunshine's message of "Fri, 7 Oct 2022 23:35:39 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Fri, Oct 7, 2022 at 6:19 PM Junio C Hamano <gitster@pobox.com> wrote:
>> [...]
>> One thing that is slightly irritating, however, is that I do not
>> think there is a good way (other than "cat .git/HEAD") to learn that
>> you checked out 'maint' to get into that state. Just like the output
>> of "git branch --show-current" shows above, "git symbolic-ref HEAD"
>> would report 'refs/heads/maint-2.38', bypassing the intermediate
>> symbolic ref at 'refs/heads/maint' that is pointed at by HEAD.
>>
>> The internal resolve_ref() API already has the necessary support for
>> stopping after resolving a single level of a symbolic-ref, and we
>> can expose it by adding a "--[no-]recurse" option to the command.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>> builtin/symbolic-ref.c | 16 ++++++++++------
>> t/t1401-symbolic-ref.sh | 14 ++++++++++++++
>> 2 files changed, 24 insertions(+), 6 deletions(-)
>
> Should this be accompanied by a documentation update or is the patch
> intended as an RFC?
It started its life as an RFC but I had an actual need during
today's integration run ;-). Will try to come up with a
documentation patch when I have time.
Thanks.
next prev parent reply other threads:[~2022-10-08 4:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 22:00 [PATCH] symbolic-ref: teach "--[no-]recurse" option Junio C Hamano
2022-10-08 3:35 ` Eric Sunshine
2022-10-08 4:20 ` Junio C Hamano [this message]
2022-10-08 4:34 ` [PATCH v2] " Junio C Hamano
2022-10-08 4:54 ` Eric Sunshine
2022-10-09 4:41 ` Junio C Hamano
2022-10-08 9:37 ` Bagas Sanjaya
2022-10-09 12:47 ` Junio C Hamano
2022-10-08 12:28 ` Philip Oakley
2022-10-08 15:28 ` Philip Oakley
2022-10-09 12:07 ` Junio C Hamano
2022-10-11 14:49 ` Philip Oakley
2022-10-09 22:13 ` [PATCH v3] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jwfc5er.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).