From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2022, #04; Thu, 15)
Date: Sun, 18 Sep 2022 18:25:18 -0700 [thread overview]
Message-ID: <xmqq4jx4dukh.fsf@gitster.g> (raw)
In-Reply-To: <20220918172659.mjkvdpryr3iaitys@tb-raspi4> ("Torsten Bögershausen"'s message of "Sun, 18 Sep 2022 19:26:59 +0200")
Torsten Bögershausen <tboegi@web.de> writes:
>> * tb/diffstat-with-utf8-strwidth (2022-09-14) 1 commit
>> - diff.c: use utf8_strwidth() to count display width
>>
>> "git diff --stat" etc. were invented back when everything was ASCII
>> and strlen() was a way to measure the display width of a string;
>> adjust them to compute the display width assuming UTF-8 pathnames.
>>
>> Expecting a reroll.
>> source: <20220914151333.3309-1-tboegi@web.de>
>>
>
> Just a question:
> Is the patch good "as is" ?
I thought I spotted and pointed out a few remaining bugs?
> Further developments need to go into different patches anyway.
> /Torsten
But these two bugs affect how the width of the lines is computed,
the computation for same number the patch tries to fix, so leaving
them broken would not make the end result any better than status
quo, no?
prev parent reply other threads:[~2022-09-19 1:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 2:47 What's cooking in git.git (Sep 2022, #04; Thu, 15) Junio C Hamano
2022-09-18 17:26 ` Torsten Bögershausen
2022-09-19 1:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jx4dukh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).