From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] Documentation/config: note trailing newline with --type=color
Date: Thu, 07 Mar 2019 12:47:40 +0900 [thread overview]
Message-ID: <xmqq4l8fny5f.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190307025821.GB25656@sigill.intra.peff.net> (Jeff King's message of "Wed, 6 Mar 2019 21:58:21 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Mar 06, 2019 at 03:52:38PM -0800, Taylor Blau wrote:
>
>> In 63e2a0f8e9 (builtin/config: introduce `color` type specifier,
>> 2018-04-09), `--type=color` was introduced and preferred to the
>> old-style `--get-color`.
>>
>> The two behave the same in almost every way, save for the fact that
>> `--type=color` prints a trailing newline where `--get-color` does not.
>> Instead of introducing ambiguity between `--type=color` and the other
>> `--type` variants, document the difference between `--type=color` and
>> `--get-color` instead.
>
> I just responded to the one Junio posted elsewhere in the thread, but
> for the record this one is fine to me, too (and it gets the literal
> quoting right ;) ).
Yeah, I haven't reached that message when I was doing mine. Other
than "co-authored-by", which probably is not quite correct (i.e. I
would have added "[tb: wrapped it up with a commit log message]" and
kept you as the author, if I were doing it), I do not have a problem
with Taylor's version, either.
prev parent reply other threads:[~2019-03-07 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:40 [PATCH] builtin/config.c: don't print a newline with --color Taylor Blau
2019-03-02 12:34 ` Eric Sunshine
2019-03-02 20:25 ` Johannes Schindelin
2019-03-03 17:24 ` Jeff King
2019-03-05 15:59 ` Johannes Schindelin
2019-03-06 23:44 ` Taylor Blau
2019-03-03 1:18 ` Junio C Hamano
2019-03-03 17:42 ` Jeff King
2019-03-04 4:28 ` Junio C Hamano
2019-03-04 5:05 ` Junio C Hamano
2019-03-05 4:20 ` Jeff King
2019-03-05 5:57 ` Junio C Hamano
2019-03-06 23:42 ` Taylor Blau
2019-03-07 0:50 ` Junio C Hamano
2019-03-07 2:57 ` Jeff King
2019-03-06 23:52 ` [PATCH v2] Documentation/config: note trailing newline with --type=color Taylor Blau
2019-03-07 2:58 ` Jeff King
2019-03-07 3:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4l8fny5f.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).