git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 7/7] config.mak.uname: use pkgsrc perl for NetBSD
Date: Mon, 26 Nov 2018 15:53:09 +0900	[thread overview]
Message-ID: <xmqq4lc4xrca.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <f7a41204f9c70e3c659877412719f17dc9805589.1543143503.git.carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Sun, 25 Nov 2018 03:06:50 -0800")

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

> otherwise will default to /usr/bin/perl which wouldn't normally exist
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

I do not have experience with NetBSD so I take your words on face
value.  This patch makes sense to me.

Thanks.

> diff --git a/config.mak.uname b/config.mak.uname
> index 59ce03819b..d2edb723f4 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -249,6 +249,7 @@ ifeq ($(uname_S),NetBSD)
>  	OLD_ICONV = UnfortunatelyYes
>  	BASIC_CFLAGS += -I/usr/pkg/include
>  	BASIC_LDFLAGS += -L/usr/pkg/lib $(CC_LD_DYNPATH)/usr/pkg/lib
> +	PERL_PATH = /usr/pkg/bin/perl
>  	USE_ST_TIMESPEC = YesPlease
>  	HAVE_PATHS_H = YesPlease
>  	HAVE_BSD_SYSCTL = YesPlease

  reply	other threads:[~2018-11-26  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 11:06 [RFC PATCH 0/7] test: NetBSD support Carlo Marcelo Arenas Belón
2018-11-25 11:06 ` [RFC PATCH 1/7] Documentation: update INSTALL for NetBSD Carlo Marcelo Arenas Belón
2018-11-26  6:27   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 2/7] t0301: remove trailing / for dir creation Carlo Marcelo Arenas Belón
2018-11-26  6:40   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 3/7] config.mak.uname: NetBSD uses BSD semantics with fread for directories Carlo Marcelo Arenas Belón
2018-11-26  6:41   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface Carlo Marcelo Arenas Belón
2018-11-26  6:45   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 5/7] test-lib: use pkgsrc provided unzip for NetBSD Carlo Marcelo Arenas Belón
2018-11-26  6:50   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 6/7] t5004: use GNU tar to avoid known issues with BSD tar Carlo Marcelo Arenas Belón
2018-11-26  6:52   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 7/7] config.mak.uname: use pkgsrc perl for NetBSD Carlo Marcelo Arenas Belón
2018-11-26  6:53   ` Junio C Hamano [this message]
2018-11-26 15:42 ` [RFC PATCH 0/7] test: NetBSD support Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4lc4xrca.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).