From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: Paul Tan <pyokagan@gmail.com>, Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] pull: add angle brackets to usage string
Date: Fri, 16 Oct 2015 10:42:49 -0700 [thread overview]
Message-ID: <xmqq4mhqg15y.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAMMLpeQPngq-xM2vN4uX6+k5-uoOXyP3p0wgLO9LOkWxWtZBEA@mail.gmail.com> (Alex Henrie's message of "Fri, 16 Oct 2015 10:42:45 -0600")
Alex Henrie <alexhenrie24@gmail.com> writes:
> 2015-10-16 10:36 GMT-06:00 Junio C Hamano <gitster@pobox.com>:
>> Makes sense, as all the other <placeholders> in the usage string are
>> bracketted.
>>
>> Does it make sense to do this for contrib/examples, which is the
>> historical record, though?
>
> I didn't know that contrib/examples was a historical record. The last
> patch I submitted, b7447679e84ed973430ab19fce87f56857b83068, also
> modified contrib/examples.
Yes, but that fixes historical "mistake", no?
With this, you are breaking historical practice by changing only one
instance to deviate from the then-current practice of saying
'options' without brackets. It is based on the point of view that
considers anything inside <bracket> and a fixed string 'options' are
meant to be replaced by intelligent readers, which is as valid as
the more recent practice to consider only things inside <bracket>
are placeholders.
next prev parent reply other threads:[~2015-10-16 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 2:22 [PATCH] pull: add angle brackets to usage string Alex Henrie
2015-10-16 16:36 ` Junio C Hamano
2015-10-16 16:42 ` Alex Henrie
2015-10-16 17:42 ` Junio C Hamano [this message]
2015-10-19 17:27 ` Alex Henrie
2015-10-20 5:17 ` Junio C Hamano
2015-10-20 16:54 ` Alex Henrie
2015-10-20 18:18 ` Junio C Hamano
2015-10-16 17:24 ` Ralf Thielow
2015-10-16 17:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mhqg15y.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).