Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Hussain Sitamouwala <husainsitamuwala21@gmail.com>
Subject: Re: [PATCH] partial-clone: document promisor remote fetch ordering
Date: Sat, 07 Nov 2026 14:55:29 -0800	[thread overview]
Message-ID: <xmqq5wy89rq6.fsf@gitster.g> (raw)
In-Reply-To: <20261107150433.17540-1-husainsitamuwala21@gmail.com> (Hussain Sitamouwala's message of "Sat, 7 Nov 2026 15:04:33 +0000")

Hussain Sitamouwala <husainsitamuwala21@gmail.com> writes:

> Document that accepted promisor remotes are tried before other promisor remotes, and that Git falls back to the next remote when a fetch fails.

Hussain, the above line is overly long.  Usual line-length
limitation rules for this mailing list applies (~70 columns).

Hussain, where did this documentation update come from?  What
prompted you to make this update?  Is this documenting a
long-standing existing behaviour?  Is this trying to fill
documentation gap left by more recent behaviour change?  Something
else?

Christian, does the behaviour this patch documents the current one?
How does it relate to 8808e61fd3 (promisor-remote: try accepted
remotes before others in get_direct(), 2026-04-07) which you did?

It seems there are multiple people sending messages with words like
"promisor", "fetch", "order", and "Outreachy" on their "Subject:"
fairly recently, but are you in charge of herding these folks, or is
somebody else helping them?  Without knowing if there is somebody
central coordinating these that I can ask about, it is hard to tell
if these people are making coherent effort to achieve something
worthwhile, or if they are just randomly banging the door.

Thanks.

> Signed-off-by: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
> ---
>  Documentation/technical/partial-clone.adoc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/technical/partial-clone.adoc b/Documentation/technical/partial-clone.adoc
> index 18718a3840..9720b856ce 100644
> --- a/Documentation/technical/partial-clone.adoc
> +++ b/Documentation/technical/partial-clone.adoc
> @@ -195,7 +195,9 @@ cache servers for fetching missing blobs while continuing to do
>  filtered `git-fetch` commands from the central server.
>  
>  When fetching objects, promisor remotes are tried one after the other
> -until all the objects have been fetched.
> +until all the objects have been fetched. Promisor remotes accepted from a
> +server are tried before other promisor remotes. If a fetch from a remote fails,
> +Git tries the remaining objects from the next remote.
>  
>  Remotes that are considered "promisor" remotes are those specified by
>  the following configuration variables:

      reply	other threads:[~2026-11-07 22:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 15:04 [PATCH] partial-clone: document promisor remote fetch ordering Hussain Sitamouwala
2026-11-07 22:55 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5wy89rq6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=husainsitamuwala21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox