From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Jeff King <peff@peff.net>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v3 00/12] coverity: fix unchecked returns
Date: Wed, 12 Aug 2026 10:29:33 -0700 [thread overview]
Message-ID: <xmqq5x1fxn5u.fsf@gitster.g> (raw)
In-Reply-To: <pull.2179.v3.git.1786521801.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Wed, 12 Aug 2026 08:03:08 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> This is the next batch of fixes in response to issues reported by Coverity.
>
> Changes since v2:
>
> * Added a new commit to handle block-writer initialization errors (instead
> of ignoring them).
> * The bw->zstream attribute is now also deinitialized in the error case, as
> suggested by Junio.
> * The commit message of "reftable/block: check deflateInit() return value"
> was rephrased to stop suggesting that silent corruption by zlib would be
> possible before that patch: This turned out to be provably incorrect.
> * When aborting the bisect because dup2() failed, a left-over saved_stdout
> is now also cleaned up.
Everything looks sensible. I am fine with declaring victory, but
does anyone want to second it?
prev parent reply other threads:[~2026-08-12 17:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 22:48 [PATCH 00/11] coverity: fix unchecked returns Johannes Schindelin via GitGitGadget
2026-07-14 22:48 ` [PATCH 01/11] http: die on curl_easy_duphandle failure in get_active_slot Johannes Schindelin via GitGitGadget
2026-07-14 22:48 ` [PATCH 02/11] config: propagate launch_editor() failure in show_editor() Johannes Schindelin via GitGitGadget
2026-07-15 6:58 ` Patrick Steinhardt
2026-07-14 22:48 ` [PATCH 03/11] reftable/block: check deflateInit() return value Johannes Schindelin via GitGitGadget
2026-07-14 22:48 ` [PATCH 04/11] reftable tests: check reftable_table_init_ref_iterator() return Johannes Schindelin via GitGitGadget
2026-07-14 22:48 ` [PATCH 05/11] last-modified: handle repo_parse_commit() failures Johannes Schindelin via GitGitGadget
2026-07-15 1:15 ` Junio C Hamano
2026-07-20 5:09 ` Junio C Hamano
2026-08-05 14:27 ` Johannes Schindelin
2026-07-14 22:48 ` [PATCH 06/11] compat/pread: check initial lseek for errors Johannes Schindelin via GitGitGadget
2026-07-15 6:58 ` Patrick Steinhardt
2026-08-05 14:29 ` Johannes Schindelin
2026-07-14 22:48 ` [PATCH 07/11] transport-helper: check dup() return in get_exporter Johannes Schindelin via GitGitGadget
2026-07-15 6:58 ` Patrick Steinhardt
2026-07-14 22:48 ` [PATCH 08/11] transport-helper: warn when export-marks file cannot be finalized Johannes Schindelin via GitGitGadget
2026-07-14 22:48 ` [PATCH 09/11] bisect: check strbuf_getline_lf return when reading terms Johannes Schindelin via GitGitGadget
2026-07-15 1:17 ` Junio C Hamano
2026-07-20 5:09 ` Junio C Hamano
2026-08-05 14:33 ` Johannes Schindelin
2026-07-14 22:48 ` [PATCH 10/11] bisect: check get_terms return at all call sites Johannes Schindelin via GitGitGadget
2026-07-15 6:58 ` Patrick Steinhardt
2026-08-05 14:57 ` Johannes Schindelin
2026-07-14 22:48 ` [PATCH 11/11] bisect: handle dup() failure when redirecting stdout Johannes Schindelin via GitGitGadget
2026-07-15 6:58 ` Patrick Steinhardt
2026-08-05 16:44 ` Johannes Schindelin
2026-08-05 18:30 ` [PATCH v2 00/11] coverity: fix unchecked returns Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 01/11] http: die on curl_easy_duphandle failure in get_active_slot Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 02/11] config: propagate launch_editor() failure in show_editor() Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 03/11] reftable/block: check deflateInit() return value Johannes Schindelin via GitGitGadget
2026-08-06 1:11 ` Junio C Hamano
2026-08-05 18:30 ` [PATCH v2 04/11] reftable tests: check reftable_table_init_ref_iterator() return Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 05/11] last-modified: handle repo_parse_commit() failures Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 06/11] compat/pread: check initial lseek for errors Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 07/11] transport-helper: check dup() return in get_exporter Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 08/11] transport-helper: warn when export-marks file cannot be finalized Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 09/11] bisect: check strbuf_getline_lf return when reading terms Johannes Schindelin via GitGitGadget
2026-08-05 18:30 ` [PATCH v2 10/11] bisect: check get_terms return at all call sites Johannes Schindelin via GitGitGadget
2026-08-05 20:26 ` Junio C Hamano
2026-08-05 18:31 ` [PATCH v2 11/11] bisect: handle dup() failure when redirecting stdout Johannes Schindelin via GitGitGadget
2026-08-06 15:41 ` Jeff King
2026-08-06 17:31 ` Junio C Hamano
2026-08-12 8:03 ` [PATCH v3 00/12] coverity: fix unchecked returns Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 01/12] http: die on curl_easy_duphandle failure in get_active_slot Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 02/12] config: propagate launch_editor() failure in show_editor() Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 03/12] reftable: handle block-writer initialization errors Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 04/12] reftable/block: check deflateInit() return value Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 05/12] reftable tests: check reftable_table_init_ref_iterator() return Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 06/12] last-modified: handle repo_parse_commit() failures Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 07/12] compat/pread: check initial lseek for errors Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 08/12] transport-helper: check dup() return in get_exporter Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 09/12] transport-helper: warn when export-marks file cannot be finalized Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 10/12] bisect: check strbuf_getline_lf return when reading terms Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 11/12] bisect: check get_terms return at all call sites Johannes Schindelin via GitGitGadget
2026-08-12 8:03 ` [PATCH v3 12/12] bisect: handle dup() failure when redirecting stdout Johannes Schindelin via GitGitGadget
2026-08-12 17:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5x1fxn5u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox