public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mirko Faina <mroik@delayed.space>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH] t4014: fix call to `test_expect_success ()`
Date: Tue, 24 Mar 2026 08:38:49 -0700	[thread overview]
Message-ID: <xmqq5x6l2q5y.fsf@gitster.g> (raw)
In-Reply-To: <acKqvI0EhaORjoD7@exploit> (Mirko Faina's message of "Tue, 24 Mar 2026 16:18:35 +0100")

Mirko Faina <mroik@delayed.space> writes:

> On Tue, Mar 24, 2026 at 03:52:30PM +0100, Patrick Steinhardt wrote:
>> We have added a couple of new tests to t4014 in 6005932d95
>> (format-patch: add ability to use alt cover format, 2026-03-07). One of
>> the tests has typoed the call to `test_expect_success ()` and instead
>> invokes `test_expected_success ()`. Fix this.
>> 
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>> Hi,
>> 
>> this fixes a test bug in one of the new tests introduced via
>> "mf/format-patch-cover-letter-format". Thanks!
>> 
>> Patrick
>
> This has already been fixed in a follow-up series under
> mf/format-patch-cover-letter-format [1].
>
> Thank you
>
> [1] https://lore.kernel.org/git/5d061d6398bae368a7cc95700b5df44854d1d8e8.1774284699.git.mroik@delayed.space

Could either of you remind us why "make test" did not catch this?

Thanks.

  reply	other threads:[~2026-03-24 15:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 14:52 [PATCH] t4014: fix call to `test_expect_success ()` Patrick Steinhardt
2026-03-24 15:18 ` Mirko Faina
2026-03-24 15:38   ` Junio C Hamano [this message]
2026-03-24 15:48     ` Mirko Faina
2026-03-24 16:39       ` Junio C Hamano
2026-03-24 17:13         ` Re* " Junio C Hamano
2026-03-24 18:05           ` [PATCH] t6002: make test "set -e" clean Junio C Hamano
2026-03-24 18:13           ` [PATCH] test-lib: catch misspelt 'test_expect_successo' Junio C Hamano
2026-03-24 19:35             ` Jeff King
2026-03-24 19:48               ` Junio C Hamano
2026-03-25  5:46                 ` Jeff King
2026-03-24 18:20           ` [PATCH] t0008: make test "set -e" clean Junio C Hamano
2026-03-24 18:32           ` [PATCH] t7450: " Junio C Hamano
2026-03-24 18:38             ` Eric Sunshine
2026-03-24 19:03               ` Junio C Hamano
2026-03-25  7:07           ` Re* [PATCH] t4014: fix call to `test_expect_success ()` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5x6l2q5y.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mroik@delayed.space \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox