From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: ds/sparse-checkout-clean
Date: Wed, 08 Oct 2025 09:21:18 -0700 [thread overview]
Message-ID: <xmqq5xcpgy9t.fsf@gitster.g> (raw)
In-Reply-To: <3537e220-44b6-4e37-a568-cef34a2fddfd@gmail.com> (Derrick Stolee's message of "Fri, 26 Sep 2025 09:42:10 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 9/25/2025 6:06 PM, Junio C Hamano wrote:
>
>> * ds/sparse-checkout-clean (2025-09-12) 7 commits
>> (merged to 'next' on 2025-09-25 at 00b296f153)
>> + t: expand tests around sparse merges and clean
>> + sparse-index: point users to new 'clean' action
>> + sparse-checkout: add --verbose option to 'clean'
>> + dir: add generic "walk all files" helper
>> + sparse-checkout: match some 'clean' behavior
>> + sparse-checkout: add basics of 'clean' command
>> + sparse-checkout: remove use of the_repository
>>
>> "git sparse-checkout" subcommand learned a new "clean" action to
>> prune otherwise unused working-tree files that are outside the
>> areas of interest.
>>
>> Will merge to 'master'.
>> source: <pull.1941.v3.git.1757673011.gitgitgadget@gmail.com>
>
> I should have checked here first, but I pinged the patch series
> to see if Elijah wanted to give another round of review following
> his careful review of v2. If there is minor feedback, then maybe
> I can forward-fix on top of this branch.
Thanks.
https://lore.kernel.org/git/CABPp-BEEHsFwE-bDjcUoDtAYm9pvVN0tGUaoh0KPEJu23LywOQ@mail.gmail.com/
which Elijah concludes with:
Yeah, I think I was hoping that patch 8 would instead be modified to
handle the additional cases (or more patches added to make it all work
out), but punting that for future work seems viable too.
In summary, I think this series is close to ready to merge, but I
think a couple wording improvements to an error message and advice
message that I called out in separate emails on this series makes
sense to fix up first.
Thanks for working on this!
unblocks this topic, I think.
Thanks, both, for working well together.
next prev parent reply other threads:[~2025-10-08 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 22:06 What's cooking in git.git (Sep 2025, #10; Thu, 25) Junio C Hamano
2025-09-26 13:42 ` ds/sparse-checkout-clean (was: What's cooking in git.git (Sep 2025, #10; Thu, 25)) Derrick Stolee
2025-10-08 16:21 ` Junio C Hamano [this message]
2025-09-29 18:13 ` What's cooking in git.git (Sep 2025, #10; Thu, 25) Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xcpgy9t.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).