From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] combine-diff: don't override recursive flag in diff_tree_combined()
Date: Fri, 05 Sep 2025 08:27:58 -0700 [thread overview]
Message-ID: <xmqq5xdw537l.fsf@gitster.g> (raw)
In-Reply-To: <20250905-toon-fix-last-modified-v2-1-d859eeed408e@iotcl.com> (Toon Claes's message of "Fri, 05 Sep 2025 15:06:31 +0200")
Toon Claes <toon@iotcl.com> writes:
> This patch is based on 'next' at 1ba7204a04 (Merge branch
> 'kh/doc-markup-fixes' into next, 2025-09-03).
Can't you be a bit more specific? We usually say "do not build on
'next'", but what we really mean by that statement are
* Your topic may interact with some topics already in 'next', but
it is unlikely that you depend on _all_ of them. If you are
willing to depend on a few selected topics (meaning: you accept
that you have to adjust your topic when they get updated, and you
accept that you cannot graduate before all of them graduate),
identify them and build on the result of a merge of these topics
into 'master'. State how you constructed your base in your cover
letter.
* If you are truly depending on _everything_ in 'next', then stop.
Wait until all of them graduates, and then submit your topic
after that.
Thanks.
next prev parent reply other threads:[~2025-09-05 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:06 [PATCH v2] combine-diff: don't override recursive flag in diff_tree_combined() Toon Claes
2025-09-05 15:27 ` Junio C Hamano [this message]
2025-09-05 15:37 ` Kristoffer Haugsbakk
2025-09-08 12:19 ` Toon Claes
2025-09-16 7:11 ` Patrick Steinhardt
2025-09-16 15:22 ` Toon Claes
2025-09-18 5:49 ` Patrick Steinhardt
2025-09-18 8:00 ` [PATCH v3] last-modified: fix bug when some paths remain unhandled Toon Claes
2025-09-18 15:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xdw537l.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).