From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ben Zanin <bzanin@gmail.com>, Dan Allen <danallen46@gmail.com>,
git@vger.kernel.org
Subject: Re: I use whatchanged!
Date: Mon, 25 Aug 2025 08:59:22 -0700 [thread overview]
Message-ID: <xmqq5xebtmsl.fsf@gitster.g> (raw)
In-Reply-To: <20250825085428.GA367101@coredump.intra.peff.net> (Jeff King's message of "Mon, 25 Aug 2025 04:54:28 -0400")
Jeff King <peff@peff.net> writes:
> The culprit is the revs.always_show_header flag, which git-log sets but
> git-whatchanged does not. I don't think there is a way to influence it
> with an option, though. You can simplify history by giving a pathspec,
> but that can have broader changes (e.g., it may also simplify away side
> branches).
>
> I don't know if that's an option that should be added before declaring
> whatchanged dead. Arguably the git-log behavior is much more reasonable,
> but I don't know if anybody cares about being byte-for-byte identical to
> whatchanged behavior.
"git log" behaviour of showing the presence of empty commits is
reasonable in the context of "showing the log". "git whatchanged"
bbehaviour of reporting which commits changed things (either in the
whole tree, or limited by pathspec) and omitting is reasonable in
the context of "showing what commit changed these things".
I do not think byte-for-byte identical output is a requirement, but
I of course am biased ;-)
prev parent reply other threads:[~2025-08-25 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 19:20 I use whatchanged! Dan Allen
2025-08-20 20:46 ` Kristoffer Haugsbakk
[not found] ` <280B51C1-CE87-4953-89CE-6310ECEC9D61@gmail.com>
2025-08-28 6:31 ` Kristoffer Haugsbakk
2025-08-20 20:53 ` Junio C Hamano
2025-08-20 20:57 ` Ben Zanin
2025-08-25 8:54 ` Jeff King
2025-08-25 15:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xebtmsl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bzanin@gmail.com \
--cc=danallen46@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).