From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jeff King <peff@peff.net>, <git@vger.kernel.org>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v3] reflog: close leak of reflog expire entry
Date: Tue, 22 Jul 2025 16:21:02 -0700 [thread overview]
Message-ID: <xmqq5xfjrew1.fsf@gitster.g> (raw)
In-Reply-To: <fd14c857-63a8-41e7-8361-bc816d4a47c4@intel.com> (Jacob Keller's message of "Tue, 22 Jul 2025 16:10:24 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
>> This needs to pass &data.policy.opts, no?
>>
>
> You're right... I think I fixed that and forgot to actually commit it
> before sending. Ugh.
>
>> I think we might also want this test on top (or I'd be happy to see it
>> squashed in). It shows off your fix when built with SANITIZE=leak, and
>> also catches the bug that v2 of your patch had.
>>
>> -Peff
>>
>
> Sounds good. I'll send a v4 which squashes this in.
OK, or you can tell me to squash what I queued on the
jk/unleak-reflog-expire-entry topic that ends at 7c091149 (fixup!
reflog: close leak of reflog expire entry, 2025-07-22) down into a
single patch (or two to keep Peff's test saparate).
Thanks.
next prev parent reply other threads:[~2025-07-22 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 23:39 [PATCH v3] reflog: close leak of reflog expire entry Jacob Keller
2025-07-22 4:54 ` Jeff King
2025-07-22 14:09 ` Junio C Hamano
2025-07-22 23:10 ` Jeff King
2025-07-22 23:10 ` Jacob Keller
2025-07-22 23:21 ` Junio C Hamano [this message]
2025-07-22 23:22 ` Jacob Keller
2025-07-22 23:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xfjrew1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).