From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Andy Koppe <andy.koppe@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: meson-test syntax error
Date: Thu, 02 Jan 2025 06:37:52 -0800 [thread overview]
Message-ID: <xmqq5xmxwabj.fsf@gitster.g> (raw)
In-Reply-To: <Z3ah2YQSx4ZreBpK@google.com> (Jonathan Nieder's message of "Thu, 2 Jan 2025 15:25:29 +0100")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Hi,
>
> Andy Koppe wrote:
>
>> The new meson-test rule in t/Makefile causes a syntax error when the
>> default shell does not support non-standard process substitution:
>>
>> make[1]: Entering directory '/src/git/t'
>> rm -f -r 'test-results'
>> /bin/sh: 10: Syntax error: "(" unexpected
>> make[1]: *** [Makefile:119: check-meson] Error 2
>>
>> Due to this line:
>>
>> diff -u <(echo "$$meson_tests") <(echo "$$actual_tests");
>>
>> This can of course be worked around with 'make test SHELL=/bin/bash',
>> but is that expected?
>
> I ran into the same today. Let's discuss in the review thread
> (https://lore.kernel.org/git/20241213-pks-meson-ci-v2-5-634affccc694@pks.im/).
Probably this one?
<20241227-b4-pks-meson-docs-v2-11-f61e63edbfa1@pks.im>
next prev parent reply other threads:[~2025-01-02 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 12:17 meson-test syntax error Andy Koppe
2025-01-02 14:25 ` Jonathan Nieder
2025-01-02 14:37 ` Junio C Hamano [this message]
2025-01-02 15:22 ` Jonathan Nieder
2025-01-02 15:39 ` Junio C Hamano
2025-01-02 15:41 ` Junio C Hamano
2025-01-02 16:26 ` Junio C Hamano
2025-01-02 17:23 ` Andreas Schwab
2025-01-02 17:27 ` Junio C Hamano
2025-01-03 6:40 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xmxwabj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).