From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH] pack-bitmap.c: typofix in `find_boundary_objects()`
Date: Mon, 25 Nov 2024 11:29:17 +0900 [thread overview]
Message-ID: <xmqq5xoc82rm.fsf@gitster.g> (raw)
In-Reply-To: <20241122154437.GB1738455@coredump.intra.peff.net> (Jeff King's message of "Fri, 22 Nov 2024 10:44:37 -0500")
Jeff King <peff@peff.net> writes:
> There are also two curious cases added by f18b512bbb (bundle: create
> filtered bundles, 2022-03-09) that set tree/blob, but not "tag". Not
> sure if that is a bug or not.
I do not think it is a good idea to single out bundles, but I can
sort of see how it could be useful when making a partial clone that
does not have blobs. `git pack-objects --objects=tag,commit,tree`
might want to be driven when preparing pack data to populate such a
clone initially. Unifying these three object flags into "all the
others" is tempting but would close the door for such a tweak.
prev parent reply other threads:[~2024-11-25 2:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 22:50 [PATCH] pack-bitmap.c: typofix in `find_boundary_objects()` Taylor Blau
2024-11-22 0:39 ` Junio C Hamano
2024-11-22 15:41 ` Jeff King
2024-11-22 15:44 ` Jeff King
2024-11-25 2:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xoc82rm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).