git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v2 10/9] t/.gitattributes: ignore whitespace in chainlint expect files
Date: Wed, 10 Jul 2024 10:15:37 -0700	[thread overview]
Message-ID: <xmqq5xtdxj5y.fsf@gitster.g> (raw)
In-Reply-To: <20240710084704.GA2061142@coredump.intra.peff.net> (Jeff King's message of "Wed, 10 Jul 2024 04:47:04 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Jul 10, 2024 at 04:34:17AM -0400, Jeff King wrote:
>
>>   [5/9]: chainlint.pl: check line numbers in expected output
>
> I just noticed that this one throws off a bunch of whitespace errors
> when you apply it. We might want this on top of the series:

Or at the bottom ;-)  I do agree with the reasoning.

Thanks.

> -- >8 --
> Subject: t/.gitattributes: ignore whitespace in chainlint expect files
>
> The ".expect" files in t/chainlint/ are snippets of expected output from
> the chainlint script, and do not necessarily conform to our usual code
> style. Especially with the recent change to retain line numbers, blank
> lines in the input script end up with trailing whitespace as we print
> "3 " for line 3, for example. The point of these files is to match the
> output verbatim, so let's not complain about the trailing spaces.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  t/.gitattributes | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/.gitattributes b/t/.gitattributes
> index b9cea1795d..7664c6e027 100644
> --- a/t/.gitattributes
> +++ b/t/.gitattributes
> @@ -1,5 +1,5 @@
>  t[0-9][0-9][0-9][0-9]/* -whitespace
> -/chainlint/*.expect eol=lf
> +/chainlint/*.expect eol=lf -whitespace
>  /t0110/url-* binary
>  /t3206/* eol=lf
>  /t3900/*.txt eol=lf

  reply	other threads:[~2024-07-10 17:15 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 22:08 [PATCH 0/2] here-doc test bodies Jeff King
2024-07-01 22:08 ` [PATCH 1/2] test-lib: allow test snippets as here-docs Jeff King
2024-07-01 22:45   ` Eric Sunshine
2024-07-01 23:43     ` Junio C Hamano
2024-07-02  0:51     ` Jeff King
2024-07-02  1:13       ` Jeff King
2024-07-02 21:37         ` Eric Sunshine
2024-07-06  5:44           ` Jeff King
2024-07-02 21:19       ` Jeff King
2024-07-02 21:59         ` Eric Sunshine
2024-07-06  5:23           ` Jeff King
2024-07-02 21:25       ` Eric Sunshine
2024-07-02 22:36         ` Eric Sunshine
2024-07-02 22:48         ` Eric Sunshine
2024-07-06  5:31         ` Jeff King
2024-07-06  5:33           ` Jeff King
2024-07-06  6:11           ` Eric Sunshine
2024-07-06  6:47             ` Eric Sunshine
2024-07-06  6:55               ` Jeff King
2024-07-06  7:06                 ` Eric Sunshine
2024-07-06  6:54             ` Jeff King
2024-07-01 22:08 ` [PATCH 2/2] t: convert some here-doc test bodies Jeff King
2024-07-02 23:50 ` [PATCH] chainlint.pl: recognize test bodies defined via heredoc Eric Sunshine
2024-07-06  6:01   ` Jeff King
2024-07-06  6:05     ` [PATCH 1/3] chainlint.pl: fix line number reporting Jeff King
2024-07-08  5:08       ` Eric Sunshine
2024-07-08  9:10         ` Jeff King
2024-07-06  6:06     ` [PATCH 2/3] t/chainlint: add test_expect_success call to test snippets Jeff King
2024-07-06  6:09       ` Jeff King
2024-07-08  3:59         ` Eric Sunshine
2024-07-06  6:07     ` [PATCH 3/3] t/chainlint: add tests for test body in heredoc Jeff King
2024-07-08  2:43       ` Eric Sunshine
2024-07-08  8:59         ` Jeff King
2024-07-06 22:15     ` [PATCH] chainlint.pl: recognize test bodies defined via heredoc Junio C Hamano
2024-07-06 23:11       ` Jeff King
2024-07-08  3:51         ` Eric Sunshine
2024-07-08  9:08           ` Jeff King
2024-07-08 19:46             ` Eric Sunshine
2024-07-08 20:17               ` Eric Sunshine
2024-07-10  0:37                 ` Jeff King
2024-07-10  1:09             ` Jeff King
2024-07-10  3:02               ` Eric Sunshine
2024-07-10  7:06                 ` Jeff King
2024-07-10  7:29                   ` Eric Sunshine
2024-07-08  3:40     ` Eric Sunshine
2024-07-08  9:05       ` Jeff King
2024-07-08 20:06         ` Eric Sunshine
2024-07-10  0:48           ` Jeff King
2024-07-10  2:38             ` Eric Sunshine
2024-07-10  8:34 ` [PATCH v2 0/9] here-doc test bodies (now with 100% more chainlinting) Jeff King
2024-07-10  8:34   ` [PATCH v2 1/9] chainlint.pl: add test_expect_success call to test snippets Jeff King
2024-07-10  8:35   ` [PATCH v2 2/9] chainlint.pl: only start threads if jobs > 1 Jeff King
2024-07-10  8:35   ` [PATCH v2 3/9] chainlint.pl: do not spawn more threads than we have scripts Jeff King
2024-07-10  8:37   ` [PATCH v2 4/9] chainlint.pl: force CRLF conversion when opening input files Jeff King
2024-07-10  8:37   ` [PATCH v2 5/9] chainlint.pl: check line numbers in expected output Jeff King
2024-08-21  7:00     ` Eric Sunshine
2024-08-21 12:14       ` Jeff King
2024-08-21 17:02         ` Eric Sunshine
2024-07-10  8:38   ` [PATCH v2 6/9] chainlint.pl: recognize test bodies defined via heredoc Jeff King
2024-07-10  8:39   ` [PATCH v2 7/9] chainlint.pl: add tests for test body in heredoc Jeff King
2024-07-10  8:39   ` [PATCH v2 8/9] test-lib: allow test snippets as here-docs Jeff King
2024-07-10  8:39   ` [PATCH v2 9/9] t: convert some here-doc test bodies Jeff King
2024-07-10  8:47   ` [PATCH v2 10/9] t/.gitattributes: ignore whitespace in chainlint expect files Jeff King
2024-07-10 17:15     ` Junio C Hamano [this message]
2024-08-21  7:31   ` [PATCH v2 0/9] here-doc test bodies (now with 100% more chainlinting) Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xtdxj5y.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).