git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: git@vger.kernel.org
Subject: Re: RFC: indicating diff strategy in format-patch message headers
Date: Wed, 05 Jun 2024 11:22:08 -0700	[thread overview]
Message-ID: <xmqq5xuns10v.fsf@gitster.g> (raw)
In-Reply-To: <20240605-hilarious-dramatic-mushroom-7fd941@lemur> (Konstantin Ryabitsev's message of "Wed, 5 Jun 2024 14:01:38 -0400")

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> Would it make sense to have git-format-patch (and friends) include an
> additional header hinting at the options used to generate the patch? E.g.:
>
>     X-git-diff-options: algo=myers; context=3;

I doubt it.  And newer version of Git _will_ try to improve how
patch text appears to be more useful to human users, so you have
more moving parts than you'd want to even think about enumerating.

If you were to add a new e-mail header, wouldn't it make more sense
to add a patch-id header and agree on the set of options to be used
to generate that patch-id (which might be different from the setting
used to format the real patch for human and "git am" consumption)?


  reply	other threads:[~2024-06-05 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 18:01 RFC: indicating diff strategy in format-patch message headers Konstantin Ryabitsev
2024-06-05 18:22 ` Junio C Hamano [this message]
2024-06-05 18:46   ` Konstantin Ryabitsev
2024-06-05 22:26     ` Eric Wong
2024-06-07 19:53       ` Konstantin Ryabitsev
2024-06-16 23:47         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xuns10v.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).