From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2024, #04; Thu, 9)
Date: Fri, 10 May 2024 08:35:16 -0700 [thread overview]
Message-ID: <xmqq5xvl7k97.fsf@gitster.g> (raw)
In-Reply-To: <Zj3SsbHLp-gH_Jey@tanuki> (Patrick Steinhardt's message of "Fri, 10 May 2024 09:54:25 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Just in case you missed it, there was a review by Justin already [1].
"I read it and have no comments" is somewhere between "an invitation
to miss" and "it does not highlight anything, either positive or
negative. Was the topic that uninteresting and uninspiring without
anything noteworthy?".
There were mentions of a new document for reviewers, similar to
SubmittingPatches is for contributors, and it would make a good
section to document recommended ways for reviewers to demonstrate
that they understand (1) the area, (2) the goal of the patches, and
(3) the implementation presented, better.
next prev parent reply other threads:[~2024-05-10 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 22:37 What's cooking in git.git (May 2024, #04; Thu, 9) Junio C Hamano
2024-05-10 1:04 ` Junio C Hamano
2024-05-10 6:32 ` Torsten Bögershausen
2024-05-10 7:54 ` Patrick Steinhardt
2024-05-10 15:35 ` Junio C Hamano [this message]
2024-05-10 16:19 ` Patrick Steinhardt
2024-05-10 18:39 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xvl7k97.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).