From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
John Cai <johncai86@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/3] rev-list: add --allow-missing-tips to be used with --missing=...
Date: Fri, 02 Feb 2024 08:47:11 -0800 [thread overview]
Message-ID: <xmqq5xz6vmnk.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD0HwQr+qj=FrDQXJeY8PhVH1e7oErbVopgtv2X8ig7a7Q@mail.gmail.com> (Christian Couder's message of "Fri, 2 Feb 2024 12:29:25 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> I am also not happy with adding yet another dump loop like this. I did
> it because I couldn't think of a simple solution to avoid that.
FWIW, that word is "dumB" loop, if you are including the word in
your updated version.
But I am still wondering if this can be unconditionally turned on
any time --missing=... is used. Have you considered it? If we can
do that, it would eliminate the need for that extra broken loop that
will fail with "git rev-list --grep --allow-missing-tips -20 HEAD".
next prev parent reply other threads:[~2024-02-02 16:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:58 [PATCH 0/3] rev-list: allow missing tips with --missing Christian Couder
2024-02-01 11:58 ` [PATCH 1/3] revision: clarify a 'return NULL' in get_reference() Christian Couder
2024-02-01 14:53 ` Eric Sunshine
2024-02-01 16:49 ` Christian Couder
2024-02-01 11:58 ` [PATCH 2/3] t6022: fix 'even though' typo in comment Christian Couder
2024-02-01 11:58 ` [PATCH 3/3] rev-list: add --allow-missing-tips to be used with --missing= Christian Couder
2024-02-01 20:20 ` Junio C Hamano
2024-02-02 11:29 ` Christian Couder
2024-02-02 16:47 ` Junio C Hamano [this message]
2024-02-01 21:27 ` Junio C Hamano
2024-02-02 11:29 ` Christian Couder
2024-02-02 16:54 ` Junio C Hamano
2024-02-07 9:57 ` Linus Arver
2024-02-07 16:34 ` Junio C Hamano
2024-02-07 16:38 ` Christian Couder
2024-02-07 9:40 ` Linus Arver
2024-02-07 16:11 ` Christian Couder
2024-02-07 20:48 ` Linus Arver
2024-02-08 15:03 ` Christian Couder
2024-02-08 20:42 ` Linus Arver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xz6vmnk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).