From: Junio C Hamano <gitster@pobox.com>
To: <rsbecker@nexbridge.com>
Cc: "'Mohit Marathe'" <mohitmarathe@proton.me>,
"'Christian Couder'" <christian.couder@gmail.com>,
<git@vger.kernel.org>, <britton.kerin@gmail.com>,
<peff@peff.net>
Subject: Re: [GSoC][RFC] Replace use of atoi() with strtol_i(), as a microproject
Date: Wed, 10 Jan 2024 10:46:53 -0800 [thread overview]
Message-ID: <xmqq5y01auw2.fsf@gitster.g> (raw)
In-Reply-To: <004601da43ee$2b6cd0c0$82467240$@nexbridge.com> (rsbecker@nexbridge.com's message of "Wed, 10 Jan 2024 12:55:11 -0500")
<rsbecker@nexbridge.com> writes:
> I am not sure this is a good idea. The error detection inside strtol_i() reports a -1 if the supplied text value is invalid. This does not differentiate between an invalid value and a valid "-1" supplied. Replacing all instances of atoi() with strtol_i() will likely cause breakages as the error semantics are different between the two.
atoi() and strtol_i() have totally different function signatures, so
it won't be a straight replacement. The report of "-1" you mention
is only about strtol_i() reporting "have we successfully read out a
number [yes/no]?". The value we parsed goes to a separate location,
so there is no risk of confusion as long as the caller knows what it
is doing.
Thanks.
next prev parent reply other threads:[~2024-01-10 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 17:34 [GSoC][RFC] Replace use of atoi() with strtol_i(), as a microproject mohitmarathe
2024-01-09 9:56 ` Christian Couder
2024-01-10 17:38 ` Mohit Marathe
2024-01-10 17:55 ` rsbecker
2024-01-10 18:46 ` Junio C Hamano [this message]
2024-01-10 18:44 ` Junio C Hamano
2024-01-12 13:04 ` Mohit Marathe
2024-01-17 5:28 ` Mohit Marathe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5y01auw2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=britton.kerin@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=mohitmarathe@proton.me \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).