git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH v4] tests: adjust whitespace in chainlint expectations
Date: Fri, 15 Dec 2023 08:44:43 -0800	[thread overview]
Message-ID: <xmqq5y0zmn44.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSNZ75WSjxfJFoVPBTkv7yQpxGz1c4ugCyQRLytpNLjig@mail.gmail.com> (Eric Sunshine's message of "Fri, 15 Dec 2023 02:17:20 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Aside: I was rather surprised to see this output from git-am when applying v4:
>
>     Applying: tests: adjust whitespace in chainlint expectations
>     .git/rebase-apply/patch:205: new blank line at EOF.
>     +
>     .git/rebase-apply/patch:219: new blank line at EOF.
>     +
>     warning: 2 lines add whitespace errors.
>
> But upon investigating the two "test" files in question,
> dqstring-line-splice.test and dqstring-no-interpolate.test, I recalled
> that I had to play tricks to escape the single-quote context created
> by the Makefile when generating t/chainlinttmp/tests in order to allow
> chainlint.pl to see a double-quoted string. So, the abovementioned
> blank lines are indeed expected output from chainlint.pl given the
> tricks played.

Thanks for being extra careful while reviewing.


      reply	other threads:[~2023-12-15 16:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 11:32 [PATCH] tests: prefer host Git to verify chainlint self-checks Patrick Steinhardt
2023-12-12 19:30 ` Junio C Hamano
2023-12-13  7:20   ` Patrick Steinhardt
2023-12-13 15:11     ` Junio C Hamano
2023-12-14  3:33       ` Eric Sunshine
2023-12-14  8:13         ` Patrick Steinhardt
2023-12-14  8:39           ` Eric Sunshine
2023-12-14  8:40             ` Patrick Steinhardt
2023-12-14 16:16             ` Junio C Hamano
2023-12-14 18:10               ` Eric Sunshine
2023-12-14 19:13                 ` Junio C Hamano
2023-12-15  5:33                 ` Patrick Steinhardt
2023-12-14  8:30 ` [PATCH v2] tests: adjust whitespace in chainlint expectations Patrick Steinhardt
2023-12-14  8:44   ` Eric Sunshine
2023-12-15  6:04 ` [PATCH v3] " Patrick Steinhardt
2023-12-15  6:24   ` Eric Sunshine
2023-12-15  6:29     ` Patrick Steinhardt
2023-12-15  6:40       ` Eric Sunshine
2023-12-15  6:42 ` [PATCH v4] " Patrick Steinhardt
2023-12-15  7:17   ` Eric Sunshine
2023-12-15 16:44     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5y0zmn44.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).