From: Junio C Hamano <gitster@pobox.com>
To: Joakim Petersen <joak-pet@online.no>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Justin Donnelly <justinrdonnelly@gmail.com>
Subject: Re: [PATCH try2] completion: prompt: use generic colors
Date: Thu, 16 Mar 2023 16:00:32 -0700 [thread overview]
Message-ID: <xmqq5yb0i9nz.fsf@gitster.g> (raw)
In-Reply-To: 9e317aa7-0037-7076-e159-3a70c581ebc1@online.no
Joakim Petersen <joak-pet@online.no> writes:
> I've played around a bit with this patch, and it seems to work as
> advertised.
As the change itself is so trivial and likely to exhibit problem
immediatly if it were not right (e.g. for some version of the shell
but not for others), let's queue it.
Thanks.
next prev parent reply other threads:[~2023-03-16 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 14:59 [PATCH try2] completion: prompt: use generic colors Felipe Contreras
2023-03-01 19:34 ` Junio C Hamano
2023-03-01 20:27 ` Felipe Contreras
2023-03-16 14:11 ` Joakim Petersen
2023-03-16 23:00 ` Junio C Hamano [this message]
2023-03-16 23:21 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5yb0i9nz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=joak-pet@online.no \
--cc=justinrdonnelly@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).