git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kir Kolyshkin <kolyshkin@gmail.com>
Cc: git@vger.kernel.org, Roman Dodin <dodin.roman@gmail.com>
Subject: Re: [PATCH] remote: align columns on -v
Date: Wed, 08 Feb 2023 08:19:39 -0800	[thread overview]
Message-ID: <xmqq5yccuo2s.fsf@gitster.g> (raw)
In-Reply-To: 20230207235238.1850757-1-kolyshkin@gmail.com

Kir Kolyshkin <kolyshkin@gmail.com> writes:

> Currently, git remote -v produces a misaligned output when a remote name
> is more than 8 characters long (i.e. longer than a tab step). Here's how
> it looks like:

The condition under which URLs do not align is not when they are
more than 8 characters long.  If all of your remotes have
10-character names, their URLs would perfectly align, no?  The
description may need to be tightened if we really wanted to do this.

But I am skeptical, even without my devil's advocate hat on.

> giuseppe	https://github.com/giuseppe/runc (fetch)
> giuseppe	https://github.com/giuseppe/runc (push)
> kir	git@github.com:kolyshkin/runc.git (fetch)
> ...

The current output allows programs to post-process by splitting each
line with a tab, but this change will break such practice and force
those who use such practice to do something different (like "split
at the first run of whitespaces or tabs").

> While at it, let's keep the \t in case some tools depend on it
> for parsing (there will still be trailing spaces in the remote name).

That will not help avoid breaking the behaviour for existing
practice (they did not need to strip the whitespaces, but now they
are forced to).  It only make the output uglier by putting mixture
of whitespaces and tabs.

So, I dunno.

Thanks.

  parent reply	other threads:[~2023-02-08 16:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 23:52 [PATCH] remote: align columns on -v Kir Kolyshkin
2023-02-08 16:12 ` Torsten Bögershausen
2023-02-08 16:32   ` Junio C Hamano
2023-02-09  1:02   ` Kirill Kolyshkin
2023-02-08 16:19 ` Junio C Hamano [this message]
2023-02-09  1:11   ` Kirill Kolyshkin
2023-02-09  1:12 ` Kir Kolyshkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yccuo2s.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dodin.roman@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kolyshkin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).