git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Kyle Meyer <kyle@kyleam.com>,
	git@vger.kernel.org, Thomas Gummerer <t.gummerer@gmail.com>,
	joostkremers@fastmail.fm
Subject: Re: [PATCH] stash: disable literal treatment when passing top pathspec
Date: Fri, 08 Apr 2022 11:47:50 -0700	[thread overview]
Message-ID: <xmqq5ynjmmy1.fsf@gitster.g> (raw)
In-Reply-To: <220408.868rsgc67o.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 08 Apr 2022 10:46:38 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Fri, Apr 08 2022, Bagas Sanjaya wrote:
>
>> On 08/04/22 10.12, Kyle Meyer wrote:
>>> +test_expect_success 'stash -u works with --literal-pathspecs' '
>>> +	>untracked &&
>>> +	git --literal-pathspecs stash -u &&
>>> +	test_path_is_missing untracked
>>> +'
>>
>> Why not "touch untracked" instead?
>
> The ">" form is correct here. We use "touch" when updating the timestamp
> to something in particular is important, but here we're just creating an
> empty file.

Maybe it is better to have it in CodingGuidelines or t/README?

Thanks.

  reply	other threads:[~2022-04-08 18:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  3:12 [PATCH] stash: disable literal treatment when passing top pathspec Kyle Meyer
2022-04-08  6:33 ` Bagas Sanjaya
2022-04-08  8:46   ` Ævar Arnfjörð Bjarmason
2022-04-08 18:47     ` Junio C Hamano [this message]
2022-04-08 18:46 ` Junio C Hamano
2022-04-09  4:10   ` Kyle Meyer
2022-04-11 17:55     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5ynjmmy1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=joostkremers@fastmail.fm \
    --cc=kyle@kyleam.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).