From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
git@vger.kernel.org, "Alban Gruin" <alban.gruin@gmail.com>
Subject: Re: [PATCH 0/5] avoid peeking into `struct lock_file`
Date: Wed, 06 Jan 2021 03:55:22 -0800 [thread overview]
Message-ID: <xmqq5z4as2j9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: a401a6a7-fc15-9f26-2345-651964cf7b5d@gmail.com
Derrick Stolee <stolee@gmail.com> writes:
> On 1/5/2021 2:23 PM, Martin Ågren wrote:
>> I made a comment in [1] about how we could avoid peeking into a `struct
>> lock_file` and instead use a helper function that we happen to have at
>> our disposal. I then grepped around a bit and found that we're pretty
>> good at avoiding such peeking at the moment, but that we could do
>> a bit better.
>>
>> Here's a series to avoid such `lk.tempfile.foo` in favor of
>> `get_lock_file_foo(&lk)`.
>>
>> [1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@mail.gmail.com/
>
> Thanks for being diligent and keeping the code clean.
>
> This series is good-to-go.
>
> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Thanks, both.
next prev parent reply other threads:[~2021-01-06 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 19:23 [PATCH 0/5] avoid peeking into `struct lock_file` Martin Ågren
2021-01-05 19:23 ` [PATCH 1/5] builtin/gc: don't peek " Martin Ågren
2021-01-05 19:23 ` [PATCH 2/5] commit-graph: " Martin Ågren
2021-01-05 19:23 ` [PATCH 3/5] midx: " Martin Ågren
2021-01-05 19:23 ` [PATCH 4/5] refs/files-backend: " Martin Ågren
2021-01-05 19:23 ` [PATCH 5/5] read-cache: try not to peek into `struct {lock_,temp}file` Martin Ågren
2021-01-06 2:16 ` [PATCH 0/5] avoid peeking into `struct lock_file` Derrick Stolee
2021-01-06 11:55 ` Junio C Hamano [this message]
2021-01-06 22:36 ` Junio C Hamano
2021-01-07 2:08 ` Derrick Stolee
2021-01-07 7:55 ` Martin Ågren
2021-01-07 8:19 ` Junio C Hamano
2021-01-07 18:17 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5z4as2j9.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).