From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Bert Wesarg" <bert.wesarg@googlemail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH] remote: add meaningful exit code on missing/existing
Date: Mon, 26 Oct 2020 14:00:45 -0700 [thread overview]
Message-ID: <xmqq5z6wem82.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201026194519.GB16150@coredump.intra.peff.net> (Jeff King's message of "Mon, 26 Oct 2020 15:45:19 -0400")
Jeff King <peff@peff.net> writes:
> This is a run-on sentence; the comma after `2` should be a period.
>
> I'd also put an Oxford comma after `rename`, but that's a stylistic
> choice. :)
Will queue with this squashed in.
Documentation/git-remote.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git c/Documentation/git-remote.txt w/Documentation/git-remote.txt
index 7c84631343..31c29c9b31 100644
--- c/Documentation/git-remote.txt
+++ w/Documentation/git-remote.txt
@@ -208,9 +208,9 @@ EXIT STATUS
On success, the exit status is `0`.
-When subcommands such as 'add', 'rename' and 'remove' can't find the
-remote in question the exit status is `2`, when the remote already
-exists the exit status is `3`.
+When subcommands such as 'add', 'rename', and 'remove' can't find the
+remote in question, the exit status is `2`. When the remote already
+exists, the exit status is `3`.
On any other error, the exit status may be any other non-zero value.
next prev parent reply other threads:[~2020-10-26 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:48 [PATCH] remote: add meaningful exit code on missing/existing Ævar Arnfjörð Bjarmason
2020-10-26 14:52 ` Eric Sunshine
2020-10-26 18:29 ` Junio C Hamano
2020-10-26 19:45 ` Jeff King
2020-10-26 21:00 ` Junio C Hamano [this message]
2020-10-27 9:41 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2020-10-26 19:55 ` [PATCH] " Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5z6wem82.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bert.wesarg@googlemail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).