git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: ydirson@free.fr
Cc: git <git@vger.kernel.org>
Subject: Re: [BUG] diff algorithm selection issue
Date: Tue, 26 May 2020 11:33:18 -0700	[thread overview]
Message-ID: <xmqq5zcio8b5.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <505382066.1036329918.1590513687177.JavaMail.root@zimbra39-e7> (ydirson@free.fr's message of "Tue, 26 May 2020 19:21:27 +0200 (CEST)")

ydirson@free.fr writes:

>> Or is it rather intended to be `--diff-algorithm=default --minimal`,
>> whatever the default may be in the future ?
>
> Now that I think about it, do we really want "minimal" as a valid choice
> for --diff-algorithm, if it's not a choice of algorithm ?

I asked the same question to myself before writing my first response
but it is way too late to ask it now.  I do support the spirit of
"--minimal", but not "--diff-algorithm=minimal" which may be an
ill-thought-out shorthand for "--diff-algorithm=default --minimal".

If you dig the list archive, I would imagine that you would find
that not an insignificant part of list participant back then thought
it was a good idea ;-)



      reply	other threads:[~2020-05-26 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <408624876.1034463388.1590484997966.JavaMail.root@zimbra39-e7>
2020-05-26  9:36 ` [BUG] diff algorithm selection issue ydirson
2020-05-26 16:10   ` Junio C Hamano
2020-05-26 16:23     ` Junio C Hamano
2020-05-26 16:56       ` ydirson
2020-05-26 17:21         ` ydirson
2020-05-26 18:33           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zcio8b5.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ydirson@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).