From: Junio C Hamano <gitster@pobox.com>
To: George Brown <321.george@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal
Date: Mon, 11 May 2020 07:31:08 -0700 [thread overview]
Message-ID: <xmqq5zd2tufn.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAFKec1VGMwn3_4AEuY8Vrs60UQbX-fvqCkzKd8VARAUScbA=rA@mail.gmail.com> (George Brown's message of "Sun, 10 May 2020 21:20:00 +0100")
George Brown <321.george@gmail.com> writes:
> Yes. Another version that someone else implemented used similar method
> by unsetting "$GIT_EDITOR" when invoked from Vim and modified "git jump"
> to use cat when "$GIT_EDITOR" was empty.
That's curious, because with the same approach, that someone else
could have gone one step further to set GIT_EDITOR to 'cat' when vim
invokes via a macro and then there is no need to modify git-jump at
all. "Curious" because I would intuitively think that unsetting
GIT_EDITOR and setting it to a specific value, 'cat', would require
about the same amount of effort.
next prev parent reply other threads:[~2020-05-11 14:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 19:15 [PATCH] contrib/git-jump: cat output when not a terminal George Brown
2020-05-09 21:41 ` Junio C Hamano
2020-05-09 22:04 ` George Brown
2020-05-09 23:42 ` Junio C Hamano
2020-05-10 9:03 ` George Brown
2020-05-10 16:47 ` Junio C Hamano
2020-05-10 17:33 ` George Brown
2020-05-10 18:12 ` Junio C Hamano
2020-05-10 18:34 ` George Brown
2020-05-10 19:10 ` Junio C Hamano
2020-05-10 19:25 ` George Brown
2020-05-10 19:38 ` Junio C Hamano
2020-05-10 20:20 ` George Brown
2020-05-11 14:31 ` Junio C Hamano [this message]
2020-05-11 14:31 ` Jeff King
2020-05-11 15:36 ` Junio C Hamano
2020-05-11 15:42 ` Jeff King
2020-05-11 16:46 ` Re* " Junio C Hamano
2020-05-12 19:23 ` Jeff King
2020-05-12 21:30 ` Junio C Hamano
2020-05-13 4:52 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2020-05-10 20:26 Benjamin
2020-05-11 14:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zd2tufn.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=321.george@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).