git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 5/5] credential: allow wildcard patterns when matching config
Date: Thu, 20 Feb 2020 13:20:01 -0800	[thread overview]
Message-ID: <xmqq5zg19cse.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200220022413.258026-6-sandals@crustytoothpaste.net> (brian m. carlson's message of "Thu, 20 Feb 2020 02:24:13 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> From: brian m. carlson <bk2204@github.com>
>
> In some cases, a user will want to use a specific credential helper for
> a wildcard pattern, such as https://*.corp.example.com.  We have code
> that handles this already with the urlmatch code, so let's use that
> instead of our custom code.

Quite nice.  Will queue the whole series.

Thanks.

  reply	other threads:[~2020-02-20 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  2:24 [PATCH v2 0/5] Wildcard matching for credentials brian m. carlson
2020-02-20  2:24 ` [PATCH v2 1/5] mailmap: add an additional email address for brian m. carlson brian m. carlson
2020-02-20  2:24 ` [PATCH v2 2/5] t1300: add test for urlmatch with multiple wildcards brian m. carlson
2020-02-20  2:24 ` [PATCH v2 3/5] t0300: add tests for some additional cases brian m. carlson
2020-02-20  2:24 ` [PATCH v2 4/5] credential: use the last matching username in the config brian m. carlson
2020-02-20  2:24 ` [PATCH v2 5/5] credential: allow wildcard patterns when matching config brian m. carlson
2020-02-20 21:20   ` Junio C Hamano [this message]
2020-02-21  6:10 ` [PATCH v2 0/5] Wildcard matching for credentials Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zg19cse.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).