From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid
Date: Wed, 03 Jul 2019 09:46:25 -0700 [thread overview]
Message-ID: <xmqq5zoj2hi6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190703164116.GA23260@sigill.intra.peff.net> (Jeff King's message of "Wed, 3 Jul 2019 12:41:16 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jul 03, 2019 at 11:12:25AM +0200, SZEDER Gábor wrote:
>
>> On Mon, Jul 01, 2019 at 09:18:15AM -0400, Jeff King wrote:
>> > diff --git a/t/t5618-alternate-refs.sh b/t/t5618-alternate-refs.sh
>> > new file mode 100755
>> > index 0000000000..3353216f09
>> > --- /dev/null
>> > +++ b/t/t5618-alternate-refs.sh
>> > @@ -0,0 +1,60 @@
>>
>> > +test_expect_success 'log --source shows .alternate marker' '
>> > + git log --oneline --source --remotes=origin >expect.orig &&
>> > + sed "s/origin.* /.alternate /" <expect.orig >expect &&
>>
>> Unnecessary redirection, 'sed' can open that file on its own as well.
>
> Sure, but is there a compelling reason not to feed it as stdin?
FWIW I do not think it is bad to redirect into a command at all ;-)
next prev parent reply other threads:[~2019-07-03 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:11 [PATCH] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-06-28 10:18 ` Jeff King
2019-06-28 12:51 ` Derrick Stolee
2019-06-29 7:43 ` Jeff King
2019-07-01 12:25 ` Derrick Stolee
2019-07-01 12:59 ` Jeff King
2019-07-01 13:17 ` Jeff King
2019-07-01 13:17 ` [PATCH 1/2] object-store.h: move for_each_alternate_ref() from transport.h Jeff King
2019-07-01 13:23 ` Derrick Stolee
2019-07-01 13:18 ` [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-07-03 9:12 ` SZEDER Gábor
2019-07-03 16:41 ` Jeff King
2019-07-03 16:46 ` Junio C Hamano [this message]
2019-07-03 16:50 ` SZEDER Gábor
2019-07-03 17:05 ` Junio C Hamano
2019-07-01 17:02 ` [PATCH] " Taylor Blau
2019-07-02 5:29 ` Jeff King
2019-06-28 16:22 ` Junio C Hamano
2019-06-29 7:55 ` Jeff King
2019-07-01 12:26 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zoj2hi6.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).