From: Junio C Hamano <gitster@pobox.com>
To: Pranit Bauva <pranit.bauva@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] commit: add a commit.verbose config variable
Date: Thu, 10 Mar 2016 14:52:08 -0800 [thread overview]
Message-ID: <xmqq60wuc5ev.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0102015362963f6a-626ad27e-e705-4a75-93a6-55a5f75d0226-000000@eu-west-1.amazonses.com> (Pranit Bauva's message of "Thu, 10 Mar 2016 22:12:07 +0000")
Pranit Bauva <pranit.bauva@gmail.com> writes:
> + if (!strcmp(k, "commit.verbose")){
v3 did this line correctly but you somehow lost the SP between
"){". What happened?
> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> index 2ddf28c..4e123a5 100755
> --- a/t/t7507-commit-verbose.sh
> +++ b/t/t7507-commit-verbose.sh
> @@ -96,4 +96,52 @@ test_expect_success 'verbose diff is stripped out with set core.commentChar' '
> test_i18ngrep "Aborting commit due to empty commit message." err
> '
>
> +test_expect_success 'commit with commit.verbose true and no arguments' '
> +test_expect_success 'commit with commit.verbose true and --no-verbose' '
> +test_expect_success 'commit with commit.verbose false and -v' '
> +test_expect_success 'commit with commit.verbose false no arguments' '
Don't you need a test that status is not broken when the variable is
set?
next prev parent reply other threads:[~2016-03-10 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 22:12 [PATCH v4] commit: add a commit.verbose config variable Pranit Bauva
2016-03-10 22:39 ` Pranit Bauva
2016-03-10 22:52 ` Junio C Hamano [this message]
2016-03-10 23:02 ` Pranit Bauva
2016-03-10 23:01 ` Eric Sunshine
2016-03-11 0:15 ` Pranit Bauva
2016-03-11 5:44 ` Eric Sunshine
2016-03-11 8:00 ` Pranit Bauva
2016-03-11 9:39 ` Roberto Tyley
2016-03-11 10:18 ` Philip Oakley
2016-03-11 0:49 ` [PATCH v2] t/t7502 : drop duplicate test Pranit Bauva
2016-03-11 5:09 ` Pranit Bauva
2016-03-11 18:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60wuc5ev.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).