From: Junio C Hamano <gitster@pobox.com>
To: "Philip Oakley" <philipoakley@iee.org>
Cc: <kelson@shysecurity.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Duy Nguyen" <pclouds@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v2] git-config support for diff.relative setting
Date: Sat, 20 Dec 2014 18:58:56 -0800 [thread overview]
Message-ID: <xmqq61d5d7yn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CFEBFB254713492C988FED7E11475227@PhilipOakley> (Philip Oakley's message of "Sat, 20 Dec 2014 14:32:46 -0000")
"Philip Oakley" <philipoakley@iee.org> writes:
> From: <kelson@shysecurity.com>
>> By default, git-diff shows changes and pathnames relative to the
>> repository root. Setting the diff.relative config option to "true"
>> shows pathnames relative to the current directory and excludes
>> changes outside this directory (identical to "git diff --relative").
> Shouldn't this `(identical to "git diff --relative")` also be included
> in the documentation change? It would truly clarify the intenbt for
> the reader.
A configuration that sticks a non-default behaviour without a way to
revert to the default is a no-no.
There should be a way to run non-relative diff in a repository that
has the configuration set, perhaps by overriding with some command
line option (e.g. "--no-relative").
next prev parent reply other threads:[~2014-12-21 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 9:24 [PATCH v2] git-config support for diff.relative setting kelson
2014-12-20 14:32 ` Philip Oakley
2014-12-21 2:58 ` Junio C Hamano [this message]
2014-12-21 19:41 ` kelson
2014-12-21 22:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61d5d7yn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=kelson@shysecurity.com \
--cc=pclouds@gmail.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).