Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kristofer Karlsson <krka@spotify.com>
Cc: Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	 Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH] rev-list: ignore replacements in the connectivity check
Date: Tue, 03 Nov 2026 10:36:55 -0800	[thread overview]
Message-ID: <xmqq7bit92yg.fsf@gitster.g> (raw)
In-Reply-To: <CAL71e4M7yFnTzYD0eVVGRmzkzSXbU0KZ-JScQOyB4-dB5xkAHA@mail.gmail.com> (Kristofer Karlsson's message of "Tue, 3 Nov 2026 09:35:07 +0100")

Kristofer Karlsson <krka@spotify.com> writes:

> My preliminary thinking is that since replacements are
> implemented as regular refs (refs/replace/OLD -> NEW),
> their reachable objects should already be covered by
> ordinary connectivity checks when those refs are fetched
> or pushed.

You are right.  So no need to do anything extra to worry about
"doing both".  It just "ignore replacements" had a wrong connotation
that we ignore the replacing objects and only pay attention to the
connection among underlying objects that misled me.

Thanks.

  parent reply	other threads:[~2026-11-03 18:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 15:47 [PATCH] rev-list: ignore replacements in the connectivity check Kristofer Karlsson via GitGitGadget
2026-11-02 22:05 ` Junio C Hamano
2026-11-03  8:35   ` Kristofer Karlsson
2026-11-03 10:17     ` Patrick Steinhardt
2026-11-03 18:36     ` Junio C Hamano [this message]
2026-11-03  9:54 ` Karthik Nayak
2026-11-03 10:51   ` Kristofer Karlsson
2026-11-03 10:17 ` Patrick Steinhardt
2026-11-03 10:38   ` Kristofer Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7bit92yg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=krka@spotify.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox