From: Junio C Hamano <gitster@pobox.com>
To: Tilak Kumar <raaztilak07@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC PATCH] t7104: use test_path_is_file instead of test -f
Date: Mon, 26 Oct 2026 14:20:06 -0700 [thread overview]
Message-ID: <xmqq7bj4p3ax.fsf@gitster.g> (raw)
In-Reply-To: <20261026164536.50520-1-raaztilak07@gmail.com> (Tilak Kumar's message of "Mon, 26 Oct 2026 22:15:36 +0530")
Tilak Kumar <raaztilak07@gmail.com> writes:
> Use the helper so that a missing file is reported
> with a clear message instead of a silent failure.
This makes sense but what is GSoC doing in the patch title? Has the
program already been announced for 2027?
> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
> ---
> t/t7104-reset-hard.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7104-reset-hard.sh b/t/t7104-reset-hard.sh
> index c23d6e3f52..acf145e69b 100755
> --- a/t/t7104-reset-hard.sh
> +++ b/t/t7104-reset-hard.sh
> @@ -29,7 +29,7 @@ test_expect_success 'reset --hard should restore unmerged ones' '
>
> git reset --hard &&
> git ls-files --error-unmatch before/1 before/2 hello later/3 &&
> - test -f hello
> + test_path_is_file hello
>
> '
next prev parent reply other threads:[~2026-10-26 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 16:45 [GSoC PATCH] t7104: use test_path_is_file instead of test -f Tilak Kumar
2026-10-26 21:20 ` Junio C Hamano [this message]
2026-10-27 3:16 ` Tilak Raaz
2026-10-27 19:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bj4p3ax.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=raaztilak07@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox