Re: [PATCH] Makefile: pin cargo --target-dir to ./target

[Junio C Hamano <gitster@pobox.com>]

Andy Koppe <andy.koppe@gmail.com> writes:

> The problem I see with that approach is that CARGO_ARGS looks like it
> is intended for build preferences similar to CFLAGS or LDFLAGS that
> could be overridden on the make command line, whereas the target dir
> is a hard requirement of the subsequent link step.
>
> I suppose `override CARGO_ARGS += --target-dir target` would avoid
> that concern, but also set a trap because any subsequent modifications
> of the variable without `override` would be quietly ignored.

But we are already tweaking it with += in the Makefile, aren't we?

    # Rust flags
    CARGO_ARGS =
    ifndef V
    CARGO_ARGS += --quiet
    endif
    ifndef DEBUG
    CARGO_ARGS += --release
    endif