From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again
Date: Wed, 23 Sep 2026 10:59:50 -0700 [thread overview]
Message-ID: <xmqq7bkbc0h5.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFadjqtOB_9cYkrs9UBgTp0hQxu4oiV_yqzYOuiu6g45w@mail.gmail.com> (Elijah Newren's message of "Wed, 23 Sep 2026 10:48:14 -0700")
Elijah Newren <newren@gmail.com> writes:
> Longer term, I wonder whether plain "git commit" should be rejected
> while resolving conflicts for rebase, am, cherry-pick, and revert,
> with users directed to the corresponding "--continue" command. Plain
> commit has a surprising collection of behaviors:
> ...
> workflow, but I think plain "git commit" should eventually be
> disallowed as a way to resolve conflicts for other commands.
>
> That's post-2.56 work.
I would say castrating "git commit" so that it can only do a plain
vanilla committing, while it may be a very good move from everything
you said above, is post-3.0, not post-2.56, work ;-).
> For now I think either reverting (and trying
> again after the release), or recording HEAD in stopped-head seems
> preferable to relying on MERGE_MSG.
Between the two I'd say giving us a chance for a clean start is far
more preferrable than repeating "Patrick thought of MERGE_MSG and
after a few hours Phillip and Elijah thought of a more robust new
mechanism. Let's hope there is no more holes found in the newly
proposed mechanism in another few hours" after -rc2 got tagged.
next prev parent reply other threads:[~2026-09-23 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 13:16 [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again Patrick Steinhardt
2026-09-23 14:02 ` Phillip Wood
2026-09-23 14:22 ` Phillip Wood
2026-09-23 17:33 ` Junio C Hamano
2026-09-23 17:49 ` Elijah Newren
2026-09-24 6:10 ` Johannes Sixt
2026-09-27 8:04 ` Jiang Xin
2026-09-23 17:48 ` Elijah Newren
2026-09-23 17:59 ` Junio C Hamano [this message]
2026-09-23 18:23 ` Patrick Steinhardt
2026-09-23 18:33 ` Junio C Hamano
2026-09-23 18:38 ` Patrick Steinhardt
2026-09-23 19:11 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bkbc0h5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox