Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Kristofer Karlsson <krka@spotify.com>
Subject: Re: [PATCH v2] commit-reach: remove get_reachable_subset()
Date: Thu, 11 Jun 2026 10:48:18 -0700	[thread overview]
Message-ID: <xmqq7bo5nf31.fsf@gitster.g> (raw)
In-Reply-To: <ffaf26b1-c55e-43c7-84b6-f810a54f7717@gmail.com> (Derrick Stolee's message of "Thu, 11 Jun 2026 08:57:19 -0400")

Derrick Stolee <stolee@gmail.com> writes:

> Finally, a commentary: You seem to have a habit of responding to
> review feedback only through new patch versions, but I'd rather see
> some thoughts in the discussion thread as direct replies to the review,
> especially if you think you will change direction like this. Saying
> something like "Maybe I should update the method to have two walk modes"
> in a reply would have given me an opportunity to respond and perhaps
> avoided a new version that went in this direction.

Thanks for saying this.  

I haven't (yet) found it in my exchange with Kristofer, but I did
find similar irritations during review sessions with other
contributors.

I wonder if we should talk about it in the SubmittingPatches and/or
MyFirstContribution document?

      parent reply	other threads:[~2026-06-11 17:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 19:28 [PATCH] commit-reach: remove get_reachable_subset() Kristofer Karlsson via GitGitGadget
2026-06-10 15:48 ` Junio C Hamano
2026-06-10 18:25   ` Kristofer Karlsson
2026-06-10 19:29   ` Derrick Stolee
2026-06-11 11:49 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-06-11 12:57   ` Derrick Stolee
2026-06-11 13:52     ` Kristofer Karlsson
2026-06-11 14:51       ` Derrick Stolee
2026-06-11 17:48     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7bo5nf31.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=krka@spotify.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox