From: Junio C Hamano <gitster@pobox.com>
To: Jonas Rebmann <kernel@schlaraffenlan.de>
Cc: git@vger.kernel.org, Chris Down <chris@chrisdown.name>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] bisect: use selected alternate terms in status output
Date: Fri, 20 Mar 2026 22:02:35 -0700 [thread overview]
Message-ID: <xmqq7br5dbbo.fsf@gitster.g> (raw)
In-Reply-To: <xmqqfr5tdbpc.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 20 Mar 2026 21:54:23 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Sounds good.
>
>> Signed-off-by: Jonas Rebmann <kernel@schlaraffenlan.de>
>> ---
>> builtin/bisect.c | 23 +++++++++++++----------
>> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> The changes in the patch look good (but it is hard to tell if this
> is exhaustive, or there are places where good/bad are still used).
>
> Thanks.
One thing I forgot to mention. This lacks tests to protect the
feature against future breakage.
Thanks.
prev parent reply other threads:[~2026-03-21 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 18:07 [PATCH] bisect: use selected alternate terms in status output Jonas Rebmann
2026-03-21 4:54 ` Junio C Hamano
2026-03-21 5:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7br5dbbo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@chrisdown.name \
--cc=git@vger.kernel.org \
--cc=kernel@schlaraffenlan.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox