From: Junio C Hamano <gitster@pobox.com>
To: "Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
Koji Nakamaru <koji.nakamaru@gree.net>
Subject: Re: [PATCH v3] osxkeychain: define build targets in the top-level Makefile.
Date: Wed, 18 Feb 2026 09:55:55 -0800 [thread overview]
Message-ID: <xmqq7bsa7x78.fsf@gitster.g> (raw)
In-Reply-To: <pull.2046.v3.git.1771391650713.gitgitgadget@gmail.com> (Koji Nakamaru via GitGitGadget's message of "Wed, 18 Feb 2026 05:14:10 +0000")
"Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:
> +contrib/credential/osxkeychain/git-credential-osxkeychain.o: contrib/credential/osxkeychain/git-credential-osxkeychain.c GIT-CFLAGS
> + @mkdir -p contrib/credential/osxkeychain/.depend
> + $(QUIET_LINK)$(CC) -o $@ -c $(dep_args) $(compdb_args) $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) $<
I notice that many other places in the Makefile we seem to use
$(call mkdir_p_parent_template). Do we want to do so here, too?
Other than that, looking good. Thanks for updating.
next prev parent reply other threads:[~2026-02-18 17:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 18:01 [PATCH] osxkeychain: define build targets in the top-level Makefile Koji Nakamaru via GitGitGadget
2026-02-10 19:50 ` Junio C Hamano
2026-02-10 23:16 ` Koji Nakamaru
2026-02-11 1:59 ` [PATCH v2] " Koji Nakamaru via GitGitGadget
2026-02-11 15:37 ` Junio C Hamano
2026-02-11 23:06 ` Koji Nakamaru
2026-02-16 23:45 ` D. Ben Knoble
2026-02-17 1:09 ` Koji Nakamaru
2026-02-17 13:10 ` D. Ben Knoble
2026-02-17 13:12 ` D. Ben Knoble
2026-02-17 18:05 ` Koji Nakamaru
2026-02-17 21:54 ` D. Ben Knoble
2026-02-18 4:06 ` Koji Nakamaru
2026-02-18 5:14 ` [PATCH v3] " Koji Nakamaru via GitGitGadget
2026-02-18 16:09 ` Kristoffer Haugsbakk
2026-02-18 19:11 ` Koji Nakamaru
2026-02-18 17:55 ` Junio C Hamano [this message]
2026-02-18 19:14 ` Koji Nakamaru
2026-02-19 15:25 ` Junio C Hamano
2026-02-20 1:39 ` [PATCH v4] " Koji Nakamaru via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bsa7x78.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=koji.nakamaru@gree.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox