From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
git@vger.kernel.org, "Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/4] t4xxx: don't use iconv(1) without ICONV prereq
Date: Tue, 10 Feb 2026 07:43:24 -0800 [thread overview]
Message-ID: <xmqq7bsk1u5f.fsf@gitster.g> (raw)
In-Reply-To: <aYs8zajWSixG8i3c@pks.im> (Patrick Steinhardt's message of "Tue, 10 Feb 2026 15:12:29 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> But even if the iconv binary were to come back I think it's somewhat
> sensible to assume that the iconv(1) binary may not exist when built
> with NO_ICONV. There might for example be platforms out there that have
> no iconv support at all, and the patches in this series would help
> those.
Makes sense. Thanks.
next prev parent reply other threads:[~2026-02-10 15:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 12:42 [PATCH 0/4] Fix tests with missing iconv(1) executable Patrick Steinhardt
2026-02-09 12:42 ` [PATCH 1/4] t4xxx: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-09 17:55 ` Junio C Hamano
2026-02-10 11:14 ` Torsten Bögershausen
2026-02-10 14:12 ` Patrick Steinhardt
2026-02-10 15:43 ` Junio C Hamano [this message]
2026-02-09 12:42 ` [PATCH 2/4] t4205: improve handling of ICONV prerequisite Patrick Steinhardt
2026-02-09 12:42 ` [PATCH 3/4] t5550: add ICONV prereq to tests that use "$HTTPD_URL/error" Patrick Steinhardt
2026-02-09 12:42 ` [PATCH 4/4] t6006: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-16 8:57 ` [PATCH 0/4] Fix tests with missing iconv(1) executable Christian Couder
2026-02-17 11:54 ` Patrick Steinhardt
2026-02-16 9:23 ` Christian Couder
2026-02-17 11:54 ` Patrick Steinhardt
2026-02-17 13:58 ` [PATCH v2 " Patrick Steinhardt
2026-02-17 13:58 ` [PATCH v2 1/4] t4xxx: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-17 14:48 ` Christian Couder
2026-02-17 15:18 ` Patrick Steinhardt
2026-02-17 13:58 ` [PATCH v2 2/4] t4205: improve handling of ICONV prerequisite Patrick Steinhardt
2026-02-17 13:58 ` [PATCH v2 3/4] t5550: add ICONV prereq to tests that use "$HTTPD_URL/error" Patrick Steinhardt
2026-02-17 13:58 ` [PATCH v2 4/4] t6006: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 0/5] Fix tests with missing iconv(1) executable Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 1/5] t: don't set ICONV prereq when iconv(1) is missing Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 2/5] t40xx: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 3/5] t4205: improve handling of ICONV prerequisite Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 4/5] t5550: add ICONV prereq to tests that use "$HTTPD_URL/error" Patrick Steinhardt
2026-02-19 23:49 ` Eric Sunshine
2026-02-20 8:00 ` Patrick Steinhardt
2026-02-18 4:38 ` [PATCH v3 5/5] t6006: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-18 17:46 ` Junio C Hamano
2026-02-18 6:46 ` [PATCH v3 0/5] Fix tests with missing iconv(1) executable Christian Couder
2026-02-18 7:09 ` Patrick Steinhardt
2026-02-20 8:25 ` [PATCH v4 " Patrick Steinhardt
2026-02-20 8:25 ` [PATCH v4 1/5] t: don't set ICONV prereq when iconv(1) is missing Patrick Steinhardt
2026-02-20 8:26 ` [PATCH v4 2/5] t40xx: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-20 8:26 ` [PATCH v4 3/5] t4205: improve handling of ICONV prerequisite Patrick Steinhardt
2026-02-20 8:26 ` [PATCH v4 4/5] t5550: add ICONV prereq to tests that use "$HTTPD_URL/error" Patrick Steinhardt
2026-02-20 8:26 ` [PATCH v4 5/5] t6006: don't use iconv(1) without ICONV prereq Patrick Steinhardt
2026-02-20 15:53 ` [PATCH v4 0/5] Fix tests with missing iconv(1) executable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bsk1u5f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox