public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Cc: "peff@peff.net" <peff@peff.net>,
	 "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] reset: avoid reflog update on no-op reset
Date: Fri, 23 Jan 2026 08:18:17 -0800	[thread overview]
Message-ID: <xmqq7bt8joae.fsf@gitster.g> (raw)
In-Reply-To: <SL2P216MB1885C5C9B75A38AE99E5511DA294A@SL2P216MB1885.KORP216.PROD.OUTLOOK.COM> (Pushkar Singh's message of "Fri, 23 Jan 2026 08:54:15 +0000")

Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:

> ... or to rework it in a way that preserves the reflog
> entry while addressing the underlying concern (if there is one).

I am OK as long as this patch does not come back in its current form
;-), but it is curious what "the underlying concern" is.  It sounds
like you see some problems that need to be addressed if the current
"the act of resetting to the same commit is recorded in the reflog",
but I am not sure what they are.

Thanks.

  reply	other threads:[~2026-01-23 16:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  8:54 [PATCH] reset: avoid reflog update on no-op reset Pushkar Singh
2026-01-23 16:18 ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-01-22 15:47 Pushkar Singh
2026-01-22 18:57 ` Junio C Hamano
2026-01-22 19:09   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7bt8joae.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=pushkarkumarsingh1970@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox