From: Junio C Hamano <gitster@pobox.com>
To: "Oskar Jaskólski" <oskarrro90@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: README update proposition
Date: Fri, 16 Jan 2026 09:09:53 -0800 [thread overview]
Message-ID: <xmqq7btha3ha.fsf@gitster.g> (raw)
In-Reply-To: <CAFp-0Pz_BdZwA4Pn=jUxvYu1prj0F85q+3GWSW-G6LF=cSHn8A@mail.gmail.com> ("Oskar Jaskólski"'s message of "Fri, 16 Jan 2026 12:22:39 +0100")
Oskar Jaskólski <oskarrro90@gmail.com> writes:
> @@ -16,15 +16,20 @@ standard Git installation.
> You need to have the following dependencies installed before you begin:
>
> - Git
> -- Tcl
> -- Tk
> -- wish
> -- Gitk (needed for browsing history)
> +- wish (Tcl/Tk runtime required to run the Git GUI)
> +- Gitk (optional, needed for browsing history)
Hiding the mention of Tcl/Tk may be a small regression for users
depending on what distribution is on. On Debian based systems,
"wish" is merely a virtual package and the package to install is
"tk", for example.
Is Gitk truly "optional"? When running git-gui there are a few menu
items that invoke gitk. Does the rest of the document inform users
well enough to avoid touching these features? I'd think that we
would rather want the README talk about giving a fairly complete
installation without such limitation.
The parenthesized explanation on "wish" is a good addition, though,
and we may want to keep it even if we were to drop everything else
in this patch.
> -Most of Git GUI is written in Tcl, so there is no compilation involved. Still,
> -some things do need to be done (mostly some substitutions), so you do need to
> -"build" it.
> +Git GUI is implemented in Tcl/Tk and is executed as a script via the `wish`
> +runtime. If `wish` is available in your PATH, no separate Tcl or Tk installation
> +is required.
If this were in the end-user instruction, being clear and concise
like the updated text is a very good thing, BUT because this is in
the building-and-installing section, I doubt this is a good change.
The build procedure (in git-gui/Makefile), would try to run "tclsh"
which is often found in the Tcl package, when it needs to use po2msg
on a system without msgfmt, which are all part of the install/build
procedure. Again, if somebody already built git-gui for you, I
agree that all you need to have is "wish" and "gitk", but that is
not the target audience of this section, is it?
prev parent reply other threads:[~2026-01-16 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:22 README update proposition Oskar Jaskólski
2026-01-16 17:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7btha3ha.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oskarrro90@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox