From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Elijah Newren <newren@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] commit: document that $command.signoff will not be added
Date: Thu, 18 Dec 2025 08:16:53 +0900 [thread overview]
Message-ID: <xmqq7buk1yxm.fsf@gitster.g> (raw)
In-Reply-To: <7bde8cd7-7487-4270-98e5-ab598b0a91d1@kdbg.org> (Johannes Sixt's message of "Wed, 17 Dec 2025 14:51:03 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
>> +There exists `format.signoff`, but that is a historical mistake, and
>> +it is not an excuse to pile on more mistakes of the same kind on top.
>
> I feel that we should s/pile on/pile/, but I am not a native speaker.
>
> This patch looks good with or without this change.
Thanks. "add more mistakes" should be clear for everybody, so I'll
change the verb.
next prev parent reply other threads:[~2025-12-17 23:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 16:10 Would it make sense to add a commit.signOff config? Stefan Haller
2025-12-14 16:44 ` Carlo Marcelo Arenas Belón
2025-12-14 23:44 ` Junio C Hamano
2025-12-14 23:52 ` Collin Funk
2025-12-15 1:22 ` brian m. carlson
2025-12-15 1:59 ` Junio C Hamano
2025-12-15 22:29 ` brian m. carlson
2025-12-16 1:20 ` Junio C Hamano
2025-12-16 0:17 ` Elijah Newren
2025-12-16 2:29 ` Junio C Hamano
2025-12-16 7:10 ` Johannes Sixt
2025-12-16 7:15 ` Johannes Sixt
2025-12-16 18:54 ` [PATCH v2] commit: document that $command.signoff will not be added Junio C Hamano
2025-12-16 19:48 ` Elijah Newren
2025-12-17 4:47 ` Junio C Hamano
2025-12-17 7:40 ` Elijah Newren
2025-12-17 13:51 ` Johannes Sixt
2025-12-17 23:16 ` Junio C Hamano [this message]
2025-12-19 7:33 ` Kristoffer Haugsbakk
2025-12-19 12:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7buk1yxm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=newren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).