From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Mathias Rav <m@git.strova.dk>, Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] rebase -i: use same commit's message and date with f -C
Date: Thu, 25 Sep 2025 10:08:52 -0700 [thread overview]
Message-ID: <xmqq7bxmh32z.fsf@gitster.g> (raw)
In-Reply-To: <12659f80-2934-4158-9a22-7a4c11060679@gmail.com> (Phillip Wood's message of "Thu, 25 Sep 2025 11:11:56 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Hi Mathias
>
> On 24/09/2025 16:21, Mathias Rav wrote:
>> I have never used the "amend!" autosquash feature and I was not
>> aware of
>> it until I stepped through the code in sequencer.c to implement my
>> proposed change. I think the `git commit --amend` manual explains quite
>> nicely why you could want to keep the author of one commit and the
>> message of another.
>> Before discovering "f -C" to achieve the "fixdown" behavior, as
>> Hannes
>> describes, I used "x f" to invoke my own single-letter shell script to
>> achieve the behavior I wanted, and I guess I am fine with going back to
>> that for the cases where I want to preserve author dates (which, to be
>> fair, is often not that important to me).
>
> I'd be happy to see a patch that implemented a new option for "fixup"
> that copied the author. As the discussion that Oswald linked to shows
> this is not the first time someone has wanted this functionality. The
> issue is that we don't want to change the existing behavior, not that
> we don't want to support this via a different option.
Yup, thanks for stating this more clealy than I would.
next prev parent reply other threads:[~2025-09-25 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 8:55 [PATCH] rebase -i: use same commit's message and date with f -C Mathias Rav
2025-09-23 9:21 ` Karthik Nayak
2025-09-23 15:23 ` Phillip Wood
2025-09-23 17:10 ` Ben Knoble
2025-09-23 17:37 ` Kristoffer Haugsbakk
2025-09-23 21:38 ` Junio C Hamano
2025-09-24 8:47 ` Johannes Sixt
2025-09-24 13:48 ` Phillip Wood
2025-09-24 15:21 ` Mathias Rav
2025-09-25 10:11 ` Phillip Wood
2025-09-25 17:08 ` Junio C Hamano [this message]
2025-09-24 16:54 ` Oswald Buddenhagen
2025-09-24 20:48 ` Junio C Hamano
2025-09-25 10:08 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bxmh32z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=m@git.strova.dk \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).