git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
	 collin.funk1@gmail.com, git@matthieu-moy.fr,
	 git@vger.kernel.org, kristofferhaugsbakk@fastmail.com,
	 phillip.wood@dunelm.org.uk, sunshine@sunshineco.com,
	 tmz@pobox.com
Subject: Re: [PATCH v2] contrib: update thunderbird-patch-inline
Date: Tue, 03 Jun 2025 15:12:38 -0700	[thread overview]
Message-ID: <xmqq7c1sh3u1.fsf@gitster.g> (raw)
In-Reply-To: <e524f5ef-0def-44b8-81b4-a8a13ec5eace@gmail.com> (Phillip Wood's message of "Mon, 19 May 2025 15:21:04 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> Hi Patrick
>
> On 19/05/2025 06:38, Patrick Steinhardt wrote:
>> On Fri, May 16, 2025 at 02:53:55PM +0100, Phillip Wood wrote:
>>> Changes since V1:
>>>
>>>    - removed the original definition of SEP (thanks to Junio for
>>>      pointing that out)
>> What I still don't quite understand: who is this update for? The
>> existing script is broken for years and nobody showed interest so far to
>> fix it. So I don't think it makes sense to fix the script just to keep
>> on dragging it with us.
>> If the answer is "you" then I'd be fine with it. But if the answer
>> is
>> a hypothetical "someone" then I'd honestly prefer to just remove dead
>> weight and not bother with this update.
>
> Personally I don't mind that much either way as I think using the
> "toggle line wrap" is more convenient for including patches in a mail
> (though that unfortunately only works with the current esr release and
> earlier). I agree with your previous mail that having this patch on
> the mailing list could be useful for anyone searching for this in the
> future so I re-rolled to fix the issue that Junio pointed out.

As the discussion seems to have died out here, shall I drop this
patch out of my tree?

> Note directly related to this series but looking at the format-patch
> documentation in mentions the "external editor" plugin which has been
> superseded by "external editor revived" and "toggle word wrap" which
> has been superseded by "toggle line wrap" so we should probably update
> that.

Another documentation patch may be in order either way, though.  I
am not a Thunderbird user myself so I'll let others who _do_ care
about it write one.

Thanks.


  reply	other threads:[~2025-06-03 22:12 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 14:12 [PATCH 00/10] Spring cleanup of "contrib/" Patrick Steinhardt
2025-05-06 14:12 ` [PATCH 01/10] contrib: remove "remotes2config.sh" Patrick Steinhardt
2025-05-06 19:52   ` Junio C Hamano
2025-05-07  6:27     ` Patrick Steinhardt
2025-05-07 17:21       ` Junio C Hamano
2025-05-06 14:12 ` [PATCH 02/10] contrib: remove "examples" directory Patrick Steinhardt
2025-05-06 14:12 ` [PATCH 03/10] contrib: remove remote-helper stubs Patrick Steinhardt
2025-05-06 14:12 ` [PATCH 04/10] contrib: remove "thunderbird-patch-inline" Patrick Steinhardt
2025-05-06 14:12 ` [PATCH 05/10] contrib: remove "hooks" directory Patrick Steinhardt
2025-05-06 14:12 ` [PATCH 06/10] contrib: remove "mw-to-git" Patrick Steinhardt
2025-05-06 20:34   ` Junio C Hamano
2025-05-07  9:11     ` Matthieu Moy
2025-05-06 14:12 ` [PATCH 07/10] contrib: remove "persistent-https" remote helper Patrick Steinhardt
2025-05-06 20:25   ` Junio C Hamano
2025-05-06 14:12 ` [PATCH 08/10] contrib: remove "git-resurrect.sh" Patrick Steinhardt
2025-05-06 20:11   ` Junio C Hamano
2025-05-07  6:58     ` Patrick Steinhardt
2025-05-07 17:48       ` Junio C Hamano
2025-05-07 18:36     ` Kristoffer Haugsbakk
2025-05-06 14:12 ` [PATCH 09/10] contrib: remove "emacs" directory Patrick Steinhardt
2025-05-06 19:59   ` Junio C Hamano
2025-05-06 14:12 ` [PATCH 10/10] contrib: remove "git-new-workdir" Patrick Steinhardt
2025-05-06 19:57   ` Junio C Hamano
2025-05-07  6:27     ` Patrick Steinhardt
2025-05-07 17:25       ` Junio C Hamano
2025-05-09  7:53         ` Patrick Steinhardt
2025-05-06 20:43 ` [PATCH 00/10] Spring cleanup of "contrib/" Junio C Hamano
2025-05-06 22:51   ` Eric Sunshine
2025-05-07  1:32     ` Todd Zullinger
2025-05-07  3:55       ` Eric Sunshine
2025-05-07  6:27         ` Patrick Steinhardt
2025-05-10 20:07         ` D. Ben Knoble
2025-05-12 13:10           ` Phillip Wood
2025-05-09  9:17 ` [PATCH v2 00/11] " Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 01/11] contrib: remove "remotes2config.sh" Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 02/11] contrib: remove "examples" directory Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 03/11] contrib: remove remote-helper stubs Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 04/11] contrib: remove "thunderbird-patch-inline" Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 05/11] contrib: remove "hooks" directory Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 06/11] contrib: remove "mw-to-git" Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 07/11] contrib: remove "persistent-https" remote helper Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 08/11] contrib: remove "git-resurrect.sh" Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 09/11] contrib: remove "emacs" directory Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 10/11] contrib: remove "git-new-workdir" Patrick Steinhardt
2025-05-09  9:17   ` [PATCH v2 11/11] contrib: remove "stats" directory Patrick Steinhardt
2025-05-09 23:31     ` Elijah Newren
2025-05-09 23:53   ` [PATCH v2 00/11] Spring cleanup of "contrib/" Elijah Newren
2025-05-10  0:00     ` Junio C Hamano
2025-05-12  9:39     ` Patrick Steinhardt
2025-05-12  4:05   ` [PATCH v2 04/11] contrib: remove "thunderbird-patch-inline" Collin Funk
2025-05-12 13:02     ` Phillip Wood
2025-05-12 14:45       ` Patrick Steinhardt
2025-05-12 16:22       ` Junio C Hamano
2025-05-14 15:19         ` Phillip Wood
2025-05-16 13:53       ` [PATCH v2] contrib: update thunderbird-patch-inline Phillip Wood
2025-05-16 14:05         ` Kristoffer Haugsbakk
2025-05-19  5:38         ` Patrick Steinhardt
2025-05-19  5:50           ` Collin Funk
2025-05-19 14:21           ` Phillip Wood
2025-06-03 22:12             ` Junio C Hamano [this message]
2025-05-19 15:48           ` Junio C Hamano
2025-05-10 12:30 ` [PATCH 00/10] Spring cleanup of "contrib/" Peter Krefting
2025-05-12  9:19 ` [PATCH v3 00/11] " Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 01/11] contrib: remove "remotes2config.sh" Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 02/11] contrib: remove "examples" directory Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 03/11] contrib: remove remote-helper stubs Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 04/11] contrib: remove "thunderbird-patch-inline" Patrick Steinhardt
2025-05-16 22:49     ` Junio C Hamano
2025-05-26  8:47       ` Toon Claes
2025-06-04 14:45       ` Junio C Hamano
2025-05-12  9:19   ` [PATCH v3 05/11] contrib: remove "hooks" directory Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 06/11] contrib: remove "mw-to-git" Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 07/11] contrib: remove "persistent-https" remote helper Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 08/11] contrib: remove "git-resurrect.sh" Patrick Steinhardt
2025-05-12  9:19   ` [PATCH v3 09/11] contrib: remove "emacs" directory Patrick Steinhardt
2025-05-12  9:20   ` [PATCH v3 10/11] contrib: remove "git-new-workdir" Patrick Steinhardt
2025-09-08  9:28     ` Gabriel Scherer
2025-09-08  9:58       ` Kristoffer Haugsbakk
2025-09-08 15:22         ` Gabriel Scherer
2025-09-12 18:14           ` D. Ben Knoble
2025-09-12 18:55             ` Gabriel Scherer
2025-09-12 22:21               ` Junio C Hamano
2025-09-12 20:05           ` Phillip Wood
2025-09-12 22:19             ` Junio C Hamano
2025-09-08 18:43         ` Junio C Hamano
2025-05-12  9:20   ` [PATCH v3 11/11] contrib: remove some scripts in "stats" directory Patrick Steinhardt
2025-05-13  2:53   ` [PATCH v3 00/11] Spring cleanup of "contrib/" Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c1sh3u1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=collin.funk1@gmail.com \
    --cc=git@matthieu-moy.fr \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).