From: Junio C Hamano <gitster@pobox.com>
To: Seyi Kuforiji <kuforiji98@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v3 06/10] t/unit-tests: convert reftable table test to use clar
Date: Mon, 02 Jun 2025 12:33:37 -0700 [thread overview]
Message-ID: <xmqq7c1uszu6.fsf@gitster.g> (raw)
In-Reply-To: <20250602122559.208780-7-kuforiji98@gmail.com> (Seyi Kuforiji's message of "Mon, 2 Jun 2025 13:25:54 +0100")
Seyi Kuforiji <kuforiji98@gmail.com> writes:
> diff --git a/Makefile b/Makefile
> index 3cccc73073..0227fdb3e1 100644
> --- a/Makefile
> +++ b/Makefile
> ...
> @@ -3972,4 +3972,4 @@ $(LIBGIT_HIDDEN_EXPORT): $(LIBGIT_PARTIAL_EXPORT)
> $(OBJCOPY) --localize-hidden $^ $@
>
> contrib/libgit-sys/libgitpub.a: $(LIBGIT_HIDDEN_EXPORT)
> - $(AR) $(ARFLAGS) $@ $^
> + $(AR) $(ARFLAGS) $@ $^
> \ No newline at end of file
I'll fix this up before pushing this morning's integration result
out, but here is an occasion for a quick quiz.
Can anybody tell, without running "make <something>", what this
accidental and unintended change breaks? It may be rather
surprising ;-)
next prev parent reply other threads:[~2025-06-02 19:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 12:25 [PATCH v3 00/10] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 01/10] t/unit-tests: implement clar specific reftable test helper functions Seyi Kuforiji
2025-06-02 13:23 ` Kristoffer Haugsbakk
2025-06-02 12:25 ` [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework Seyi Kuforiji
2025-06-03 13:51 ` Patrick Steinhardt
2025-06-03 14:03 ` Seyi Kuforiji
2025-06-03 14:14 ` Patrick Steinhardt
2025-06-02 12:25 ` [PATCH v3 03/10] t/unit-tests: convert reftable block test to use clar Seyi Kuforiji
2025-06-03 14:18 ` Patrick Steinhardt
2025-06-02 12:25 ` [PATCH v3 04/10] t/unit-tests: convert reftable merged " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 05/10] t/unit-tests: convert reftable pq " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 06/10] t/unit-tests: convert reftable table " Seyi Kuforiji
2025-06-02 19:33 ` Junio C Hamano [this message]
2025-06-03 11:46 ` Seyi Kuforiji
2025-06-03 19:12 ` Junio C Hamano
2025-06-02 12:25 ` [PATCH v3 07/10] t/unit-tests: convert reftable readwrite " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 08/10] t/unit-tests: convert reftable record " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 09/10] t/unit-tests: convert reftable stack " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 10/10] t/unit-tests: finalize migration of reftable-related tests Seyi Kuforiji
2025-06-03 13:51 ` Patrick Steinhardt
2025-06-05 12:56 ` Seyi Kuforiji
2025-06-05 13:24 ` Patrick Steinhardt
2025-06-05 16:56 ` Junio C Hamano
2025-06-03 18:41 ` [PATCH v3 00/10] t/unit-tests: convert unit-tests to use clar Junio C Hamano
2025-06-04 10:09 ` Seyi Kuforiji
2025-06-04 10:09 ` Seyi Kuforiji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7c1uszu6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kuforiji98@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).